Skip to content

Move std.math.exponential.pow implementation outside template #9019

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 3, 2024

Conversation

dkorpel
Copy link
Contributor

@dkorpel dkorpel commented Jun 30, 2024

  • Prevent redundant code generation for different instantiations
  • Preparing to move the implementation of ^^ to core.math

Purely a cut and paste, only this alias and the previous imports were moved inside _powImpl:

    alias F = real;
    import core.math : fabs, sqrt;
    import std.math.traits : isInfinity, isNaN, signbit;

@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @dkorpel! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + phobos#9019"

@dkorpel
Copy link
Contributor Author

dkorpel commented Jul 2, 2024

Ping @RazvanN7

@RazvanN7 RazvanN7 merged commit a6ad152 into dlang:master Jul 3, 2024
10 checks passed
RubyTheRoobster pushed a commit to RubyTheRoobster/phobos that referenced this pull request Aug 6, 2024
…g#9019)

* Move `std.math.exponential.pow` implementation outside template

* Fix compilation on Mac
RubyTheRoobster pushed a commit to RubyTheRoobster/phobos that referenced this pull request Aug 21, 2024
…g#9019)

* Move `std.math.exponential.pow` implementation outside template

* Fix compilation on Mac
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants