Skip to content

Fix bugzilla 18552: Adds check bounds of year to std.datetime.date.Date #9025

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 25, 2024

Conversation

denizzzka
Copy link
Contributor

@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @denizzzka! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + phobos#9025"

@denizzzka denizzzka force-pushed the year_check branch 3 times, most recently from 397b863 to b78e3c9 Compare July 17, 2024 12:43
@denizzzka denizzzka marked this pull request as ready for review July 17, 2024 14:18
@denizzzka denizzzka requested a review from jmdavis as a code owner July 17, 2024 14:18
try
return year.to!short;
catch (ConvOverflowException)
throw new DateTimeException(format("year %s doesn't fit to Date.", year), file, line);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's my understanding that the try-catch adds overhead. Given how often this code is going to be used with date/time stuff, it would make more sense to just check the bounds and throw rather than using to.

Copy link
Contributor Author

@denizzzka denizzzka Jul 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

try-catch for .to isn't adds overhead here: if we just check bounds manually then create DateTimeException manually it will be same cost

Overhead here is added only by cost of the second exception creation only if bounds check failed. For year field it is very rare case and such approach makes code more common and clear.

So, since we're using exceptions in this module to report errors that's fine.

@dlang-bot dlang-bot merged commit c00a5ee into dlang:master Jul 25, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants