Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweaks to Terraform + create script #4

Merged
merged 8 commits into from
Oct 12, 2023
Merged

Conversation

donaldgray
Copy link
Member

@donaldgray donaldgray commented Oct 10, 2023

Made the following changes to Terraform:

  • Removed "-cloudwatch-cron-rule" postfix from CW event name, there's a 64 char limit and this adds 22 chars.
  • Add description + types to variables.tf
  • Ran terraform fmt and remove unused region variable
  • Reduce the ssm permissions for the lambda by restricting to a specific SSM value.

In addition to the above this PR:

  • Adds a sample sql script for creating different pg users for running scripts
  • Removes 2 unused vars from entity-counter py script
  • Explicitly sets the "CustomerStorage" column names as the ordering is inconsistent between different DLCS setups (due to some created with legacy sql script and EF).

@donaldgray donaldgray changed the title Add type + description to variables Tweaks to Terraform Oct 11, 2023
@donaldgray donaldgray changed the title Tweaks to Terraform Tweaks to Terraform + create script Oct 11, 2023
Ordering of cols differs between set sql script used to create older
instances and order created by EF
@donaldgray donaldgray merged commit 2129855 into main Oct 12, 2023
4 checks passed
@donaldgray donaldgray deleted the feature/tidy_terraform branch October 12, 2023 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant