Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Calculate total items including extrapolated sum of previous pages #142

Merged
merged 2 commits into from
Nov 13, 2024
Merged

Calculate total items including extrapolated sum of previous pages #142

merged 2 commits into from
Nov 13, 2024

Conversation

p-kaczynski
Copy link
Contributor

No description provided.

donaldgray
donaldgray approved these changes Nov 13, 2024
View reviewed changes
Copy link
Member

@donaldgray donaldgray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, agree w/ Jack that a test might be useful for future ref

@p-kaczynski p-kaczynski merged commit efda0d8 into main Nov 13, 2024
3 checks passed
@p-kaczynski p-kaczynski deleted the bugfix/20241112/total_items_fix branch November 13, 2024 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JackLewis-digirati JackLewis-digirati JackLewis-digirati left review comments

@donaldgray donaldgray donaldgray approved these changes

@garyttierney garyttierney Awaiting requested review from garyttierney

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@p-kaczynski @donaldgray @JackLewis-digirati