-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add no-store to the Cache-Control header on auth responses #916
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As the issue that we encountered is related to the AccessTokenResponse
- is it worth adding tests to confirm the appropriate headings are set there? Would pick up if the attribute was somehow removed
src/protagonist/Orchestrator.Tests/Integration/AuthHandlingTests.cs
Outdated
Show resolved
Hide resolved
src/protagonist/Orchestrator.Tests/Integration/AuthHandlingTests.cs
Outdated
Show resolved
Hide resolved
Btw, |
should be changed to use just |
…ilure + more checks on tests
e7c8655
to
6993818
Compare
Related to #833
This PR adds a
Cache-Control
header ofno-cache,no-store
to the following endpoints:auth/{customer}/clickthrough
auth/{customer}/token
auth/{customer}/{authService}
auth/{customer}/{authService}/logout
This should help to avoid issues where auth responses are cached incorrectly
NOTE: this header has not been added to
auth/v2/probe/{customer}/{space}/{image}
as this resource already has aCache-Control
value ofprivate