fix(prs): Make r/R refresh properly update reviewer status as expected #746
+233
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sideshowbarker
force-pushed
the
sideshowbarker/fix-reviewer-refresh-cache
branch
2 times, most recently
from
19fd4df to
8438b10
Compare
This change fixes a bug that caused us to not be showing up-to-date status/ state in Reviewers. The fix causes the cached GraphQL client to be cleared when a refresh is requested — ensuring the next enrichment invalidates the cache, and then a request for fresh data is made over the network to GitHub. Otherwise, without this change, when pressing "r" or "R" to refresh, the enriched PR data (including reviewers) was being served from a 5-minute-TTL GraphQL cache. That meant that if someone approved the PR, and then we refreshed in dash, the reviewer status wouldn't update. Also clears the label cache on refresh, for consistency.
sideshowbarker
force-pushed
the
sideshowbarker/fix-reviewer-refresh-cache
branch
from
8438b10 to
dcc23b6
Compare
Owner
|
I honestly don't know what's our use case for caching a PR for 5 minutes. I can only think of issues it might cause. WTYT about removing it? am I missing something? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This change fixes a bug that caused us to not be showing up-to-date status/ state in Reviewers. The fix causes the cached GraphQL client to be cleared when a refresh is requested — ensuring the next enrichment invalidates the cache, and then a request for fresh data is made over the network to GitHub. Fixes #745
Otherwise, without this change, when pressing
rorRto refresh, the enriched PR data (including reviewers) was being served from a 5-minute-TTL GraphQL cache. That meant that if someone approved the PR, and then we refreshed in dash, the reviewer status wouldn't update.How did you test this change?
Includes integration test