fix: exclude archived from TotalCount

[andrewg-xyz]

Summary

• Fix count mismatch when search results include archived repositories
• Add archived:false to GitHub search queries for both PRs and issues

In #124 and #221, archived repositories were excluded from results because users can't interact with PRs/issues on archived repos. The fixes in #199 and #223 filtered archived repos client-side after fetching results, but the TotalCount returned from GitHub's API still included them, causing a mismatch between the displayed count and actual items.

How did you test this change?

• task lint
• task test
• build and run with custom gh-dash config and manually verify changes.

Images/Videos

Fixes #756

[dlvhdr]

Hey, thanks for the PR :)
I'm wondering, is there ever a reason to search for prs/issues on archived repos?
Like, what if you're the one that archived the repo, maybe you still like to see prs/issues?
I need to read about what an archived repo actually means.
If we add the is:archived filter, users aren't aware, as the search bar shows just is:pr.
Now I'm not a fan of also showing archived:false as it takes up too much space but we can add a note in the docs site.

[andrewg-xyz]

Hey, thanks for the PR :) I'm wondering, is there ever a reason to search for prs/issues on archived repos? Like, what if you're the one that archived the repo, maybe you still like to see prs/issues? I need to read about what an archived repo actually means. If we add the is:archived filter, users aren't aware, as the search bar shows just is:pr. Now I'm not a fan of also showing archived:false as it takes up too much space but we can add a note in the docs site.

I had a similar debate, but made the assumption based on prior work. Archived repos are view-only. When I figured out why there was a difference, I couldn't even close the old PR.

By default I would expect behavior to match that of GitHub's search. Considering the feature set of gh-dash, "view and take action" I like customizing the behavior to exclude archived repos since they aren't actionable. I could always view those items in GitHub UI if I really wanted to.

I'm happy to change behavior and/or update docs! But will wait for your opinion, I'm just a lowly user 😂 .

[dlvhdr]

ok cool makes sense. Let's just add a disclaimer in the docs