Skip to content

fix: fixing ProxyJump none and ProxyJump user@host #1147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

StarAurryon
Copy link

@StarAurryon StarAurryon commented Feb 7, 2025

This PR aims at adding proper support for .ssh/config file following features that are not currently supported :

  • ProxyJump none
  • ProxyJump user@host

Summary by CodeRabbit

  • Refactor
    • Enhanced SSH connection handling by separating host and user details for proxy jump configurations, ensuring more reliable SSH connectivity.
  • Tests
    • Added tests to validate the new structured parsing of proxy jump strings, confirming expected behavior in SSH configuration.

korbit-ai[bot]

This comment was marked as spam.

coderabbitai[bot]

This comment was marked as spam.

Repository owner deleted a comment from coderabbitai bot Mar 23, 2025
Repository owner deleted a comment from coderabbitai bot Mar 23, 2025
@dmacvicar
Copy link
Owner

I'd like to deprecate the current ssh transport instead of adding support to more config options, in favour of the transport based on the native ssh command.

Is there a way you could help us testing those use cases will work in the new transport instead?

@StarAurryon
Copy link
Author

Hello,

Sorry for the late reply. Yes of course !
It is always better to be lazy and don't have to maintain things on my own.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants