Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unused pin rework #17

Merged
merged 4 commits into from
Jun 6, 2024
Merged

Unused pin rework #17

merged 4 commits into from
Jun 6, 2024

Commits on Jun 6, 2024

  1. Change all pin types to use PinNum alias

    @dmadison
    dmadison committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    4a7a2eb View commit details
    Browse the repository at this point in the history

  2. Replace all NOT_A_PIN references 

    Using a value we control rather than the platform-specific define (which isn't really meant for this purpose anyways).
    @dmadison
    dmadison committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    93a4a6d View commit details
    Browse the repository at this point in the history

  3. Implement pin number sanitization 

    Treating all negative numbers as invalid pins, sanitized to UnusedPin on assignment.
    @dmadison
    dmadison committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    b56d61f View commit details
    Browse the repository at this point in the history

  4. Clean up pin arguments and definitions 

    Removing const from pin number members to allow copying, and changing argument names so that 'pin' is the prefix rather than the suffix in all cases.

This should not affect any user code.
    @dmadison
    dmadison committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    1da6619 View commit details
    Browse the repository at this point in the history