Skip to content

Commit

Permalink
Fix missing includes (#591)
Browse files Browse the repository at this point in the history
* Fix missing includes

* Use a different emulator for aarch64

* Remove deprecate Mambaforge

* Specify platform flag for Docker
  • Loading branch information
hcho3 authored Nov 1, 2024
1 parent 469fc78 commit da70beb
Show file tree
Hide file tree
Showing 7 changed files with 17 additions and 14 deletions.
6 changes: 3 additions & 3 deletions .github/workflows/coverage-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ jobs:
submodules: 'true'
- uses: conda-incubator/setup-miniconda@v3
with:
miniforge-variant: Mambaforge
miniforge-variant: Miniforge3
miniforge-version: latest
activate-environment: dev
environment-file: ops/conda_env/dev.yml
Expand All @@ -51,7 +51,7 @@ jobs:
submodules: 'true'
- uses: conda-incubator/setup-miniconda@v3
with:
miniforge-variant: Mambaforge
miniforge-variant: Miniforge3
miniforge-version: latest
activate-environment: dev
environment-file: ops/conda_env/dev.yml
Expand All @@ -74,7 +74,7 @@ jobs:
submodules: 'true'
- uses: conda-incubator/setup-miniconda@v3
with:
miniforge-variant: Mambaforge
miniforge-variant: Miniforge3
miniforge-version: latest
activate-environment: dev
environment-file: ops/conda_env/dev.yml
Expand Down
9 changes: 6 additions & 3 deletions .github/workflows/linux-wheel-builder.yml
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ jobs:
submodules: 'true'
- uses: conda-incubator/setup-miniconda@v3
with:
miniforge-variant: Mambaforge
miniforge-variant: Miniforge3
miniforge-version: latest
activate-environment: dev
environment-file: ops/conda_env/dev.yml
Expand All @@ -56,7 +56,7 @@ jobs:
submodules: 'true'
- uses: conda-incubator/setup-miniconda@v3
with:
miniforge-variant: Mambaforge
miniforge-variant: Miniforge3
miniforge-version: latest
activate-environment: dev
environment-file: ops/conda_env/dev.yml
Expand All @@ -81,11 +81,14 @@ jobs:
submodules: 'true'
- uses: conda-incubator/setup-miniconda@v3
with:
miniforge-variant: Mambaforge
miniforge-variant: Miniforge3
miniforge-version: latest
activate-environment: dev
environment-file: ops/conda_env/dev.yml
use-mamba: true
- uses: dbhi/qus/action@main
with:
targets: aarch64
- name: Build CPack
run: |
bash ops/build-cpack.sh
2 changes: 1 addition & 1 deletion .github/workflows/macos-wheel-builder.yml
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ jobs:
submodules: 'true'
- uses: conda-incubator/setup-miniconda@v3
with:
miniforge-variant: Mambaforge
miniforge-variant: Miniforge3
miniforge-version: latest
activate-environment: dev
environment-file: ops/conda_env/dev.yml
Expand Down
8 changes: 4 additions & 4 deletions .github/workflows/misc-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ jobs:
submodules: 'true'
- uses: conda-incubator/setup-miniconda@v3
with:
miniforge-variant: Mambaforge
miniforge-variant: Miniforge3
miniforge-version: latest
activate-environment: dev
environment-file: ops/conda_env/dev.yml
Expand All @@ -56,7 +56,7 @@ jobs:
submodules: 'true'
- uses: conda-incubator/setup-miniconda@v3
with:
miniforge-variant: Mambaforge
miniforge-variant: Miniforge3
miniforge-version: latest
activate-environment: dev
environment-file: ops/conda_env/dev.yml
Expand All @@ -81,7 +81,7 @@ jobs:
submodules: 'true'
- uses: conda-incubator/setup-miniconda@v3
with:
miniforge-variant: Mambaforge
miniforge-variant: Miniforge3
miniforge-version: latest
activate-environment: dev
environment-file: ops/conda_env/dev.yml
Expand All @@ -102,7 +102,7 @@ jobs:
submodules: 'true'
- uses: conda-incubator/setup-miniconda@v3
with:
miniforge-variant: Mambaforge
miniforge-variant: Miniforge3
miniforge-version: latest
activate-environment: dev
environment-file: ops/conda_env/dev.yml
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/windows-wheel-builder.yml
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ jobs:
submodules: 'true'
- uses: conda-incubator/setup-miniconda@v3
with:
miniforge-variant: Mambaforge
miniforge-variant: Miniforge3
miniforge-version: latest
activate-environment: dev
environment-file: ops/conda_env/dev.yml
Expand Down
1 change: 1 addition & 0 deletions include/treelite/model_loader.h
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
#define TREELITE_MODEL_LOADER_H_

#include <cstddef>
#include <cstdint>
#include <memory>
#include <string>
#include <string_view>
Expand Down
3 changes: 1 addition & 2 deletions ops/build-cpack.sh
Original file line number Diff line number Diff line change
Expand Up @@ -18,11 +18,10 @@ python -m awscli s3 cp build/*.tar.gz s3://treelite-cpack/ --acl public-read --r
rm -rf build/

echo "##[section] Building Treelite for aarch64..."
docker run --rm --privileged multiarch/qemu-user-static --reset -p yes
export DOCKER_DEFAULT_PLATFORM=linux/arm64/v8
tests/ci_build/ci_build.sh ubuntu20_aarch64 tests/ci_build/build_via_cmake.sh

echo "##[section] Packing CPack for aarch64..."
docker run --rm --privileged multiarch/qemu-user-static --reset -p yes
tests/ci_build/ci_build.sh ubuntu20_aarch64 bash -c "cd build/ && cpack -G TGZ"
for tgz in build/treelite-*-Linux.tar.gz
do
Expand Down

0 comments on commit da70beb

Please sign in to comment.