Skip to content

Ask approval feature for file invalidation #987

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
juanpablosalas wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Ask approval feature for file invalidation #987

juanpablosalas wants to merge 9 commits into from

Conversation

@juanpablosalas
Copy link
Contributor

@juanpablosalas juanpablosalas commented Jan 6, 2026

As per CMSTRANSF-1274,

In order to prevent accidental invalidations, a two factor approval of file invalidation requests is proposed. This would be handled via the current server in the following way:

  1. When a user sends a File Invalidation Request, it immediately enters a pending_approval state.
  2. A second user will approve said request once they review it (understand why it's being invalidated, make sure there are no RAW files - unless T0 explicitly makes said request).
  3. Once the request is approved, the request is sent and the file invalidation job is created just like it is handled nowadays.

@juanpablosalas juanpablosalas force-pushed the feature/ask_approval_file_invalidation branch from 83734fd to 4157f7f Compare January 6, 2026 18:52
@juanpablosalas
Initial version of asking approval feature
12f0ae9 
Removed deprecated HomePageView

Fixed request_id converter
@juanpablosalas juanpablosalas force-pushed the feature/ask_approval_file_invalidation branch from 4157f7f to 12f0ae9 Compare January 6, 2026 19:01
@juanpablosalas
include allowed test host
b30d4a5 
included csrf trusted origins
@juanpablosalas juanpablosalas force-pushed the feature/ask_approval_file_invalidation branch from 4a58fb5 to b30d4a5 Compare January 6, 2026 20:49
@juanpablosalas juanpablosalas force-pushed the feature/ask_approval_file_invalidation branch from 7da8df2 to 347131b Compare January 15, 2026 21:18
@juanpablosalas
add all fields to API query view
1960455 
fixed print message

fields in grouped view
@juanpablosalas juanpablosalas force-pushed the feature/ask_approval_file_invalidation branch from 347131b to 1960455 Compare January 15, 2026 21:44
@juanpablosalas
fixed e-mail configuration
eb49110 
fixed email message
@juanpablosalas juanpablosalas force-pushed the feature/ask_approval_file_invalidation branch 2 times, most recently from fda8352 to 386f4de Compare January 20, 2026 14:03
@juanpablosalas
Field mismatch fix
4956c50 
approve_user

fixed files call
@juanpablosalas juanpablosalas force-pushed the feature/ask_approval_file_invalidation branch from 386f4de to 4956c50 Compare January 20, 2026 14:45
@juanpablosalas juanpablosalas force-pushed the feature/ask_approval_file_invalidation branch 10 times, most recently from e744fc2 to 245ca73 Compare January 20, 2026 20:48
@juanpablosalas
testing
8e2be75 
rm arg list

revert testing

testing

done testing

reset space

removed extra files

removing all .txt extra files

testing

fixed text file deletion

finished testing hopefully
@juanpablosalas juanpablosalas force-pushed the feature/ask_approval_file_invalidation branch from 245ca73 to 8e2be75 Compare January 20, 2026 21:26
@juanpablosalas juanpablosalas marked this pull request as ready for review January 21, 2026 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@juanpablosalas