Adapt WMCore's buildRelase script to dbs2go needs #140
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vkuznet
requested changes
May 7, 2025
|
hi @vkuznet, I just added all I think this script should be capable of doing. And I also created a simplified Feel free to take another look. |
todor-ivanov
force-pushed
the
feature_AddBuildRelease_fixes-139
branch
from
d72eace to
ca36edf
Compare
Add default REPOURL Remove any hardwired urls in the script && Use jq to find the PR number Add user confirmation before building any release Add make release target to the Makefile Final changes Move from CHANGES file to CHANGES.md Fix commitLine entries for commits not associated with PRs Add DRYRUN mode Add protection against missing release commits && Add check of tag regexp && Estimate repoUrl from remote only Refine TAGREGEXP && Remove locking logic when remote origin is missing && Explicitely add CHANGES file to avoid broken first tag comits due to new file errors
todor-ivanov
force-pushed
the
feature_AddBuildRelease_fixes-139
branch
from
5dcec8d to
5dcd361
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #139
With the Current PR we are trying to adapt the already existing WMCore
buildReleasescript to the needs of dbs2go.