feat: 참여자 삭제기능 추가 및 리팩터링 #111
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- TimeBlockService에 create 및 remove 메서드 추가 - Participant 이벤트 핸들러 (생성/삭제) 추가 - ParticipantDeletionEvent를 ParticipantRemovedEvent로 리네임 - TimeBlock 엔티티에 관련 이벤트 등록 로직 추가 (@PreRemove) - TimeBlock, TimeTable 엔티티에 Javadoc 주석 추가 - 관련 테스트 케이스(TimeBlockEventHandlerTest, TimeBlockIntegrationTest 등) 추가
- TimeTable 업데이트를 EventHandler로 분리하여 책임 분리 - TimeBlockRemovedEvent와 TimeBlockReplaceEvent에 TimeTable 업데이트 커맨드 생성 메서드 추가 - 불필요한 TimeTableUpdateService 제거 - 관련 통합 및 단위 테스트 추가
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closed
어떤 기능을 개발했나요?
@SpringBootTest사용가능)어떻게 해결했나요?
어떤 부분에 집중하여 리뷰해야 할까요?
(option) 이 부분은 주의해 주세요.
(option) 참고자료
(option) 결과
RCA rule