Conversation
|
hmmm… to upgrade that, it bumps System.Collections.Immutable to 10.0.0 (from 9.0.2), and that bump causes errors with the source generator for some reason.
|
f156ed7 to
c27bc4e
Compare
mitchelsellers
left a comment
There was a problem hiding this comment.
This looks good with one question.
Does this upgrade result in a need for a binding redirect?
|
It will require an update to the binding redirect. It's already included in the HtmlSanitizer package, but that assembly is included in the |
So does this mean we already move forward to the new upgrade process? Meaning: not release the upgrade package and point users to the upgrade module instead? |
4f6bd39 to
7df0def
Compare
7df0def to
917718d
Compare
|
@bdukes my understanding is that this works fine with the new upgrade process and we have adjusted the documentation for that right? |
|
10.2.3 resolves an issue introduced in 10.2.2 which required using the upgrade process to avoid binding redirect issues. I'm not sure where we landed on requiring the upgrade process for 10.3.0. |
Summary
In order to avoid NU1902 error, this PR bumps HtmlSanitizer (which requires bumping System.Collections.Immutable).
Locally, this caused issues with the source generator, pushing this to CI to see if it's a local only issue.