-
Notifications
You must be signed in to change notification settings - Fork 2.5k
Update golang #18623
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Update golang #18623
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes: - docker-library/golang@0f7ef09: Merge pull request docker-library/golang#553 from infosiftr/git-for-windows
Diff for 3406ccb:diff --git a/_bashbrew-cat b/_bashbrew-cat
index 16de566..4e9f3f8 100644
--- a/_bashbrew-cat
+++ b/_bashbrew-cat
@@ -50,7 +50,7 @@ Constraints: nanoserver-ltsc2025, windowsservercore-ltsc2025
Tags: 1.23.7-windowsservercore-1809, 1.23-windowsservercore-1809
SharedTags: 1.23.7-windowsservercore, 1.23-windowsservercore, 1.23.7, 1.23
Architectures: windows-amd64
-GitCommit: 01dc540d7fbab91ada1a5ec0ae6a215ab734de31
+GitCommit: 0f7ef098851cca2bad10b356ebbcecc7b83f6f56
Directory: 1.23/windows/windowsservercore-1809
Builder: classic
Constraints: windowsservercore-1809
@@ -58,7 +58,7 @@ Constraints: windowsservercore-1809
Tags: 1.23.7-windowsservercore-ltsc2022, 1.23-windowsservercore-ltsc2022
SharedTags: 1.23.7-windowsservercore, 1.23-windowsservercore, 1.23.7, 1.23
Architectures: windows-amd64
-GitCommit: 01dc540d7fbab91ada1a5ec0ae6a215ab734de31
+GitCommit: 0f7ef098851cca2bad10b356ebbcecc7b83f6f56
Directory: 1.23/windows/windowsservercore-ltsc2022
Builder: classic
Constraints: windowsservercore-ltsc2022
@@ -66,7 +66,7 @@ Constraints: windowsservercore-ltsc2022
Tags: 1.23.7-windowsservercore-ltsc2025, 1.23-windowsservercore-ltsc2025
SharedTags: 1.23.7-windowsservercore, 1.23-windowsservercore, 1.23.7, 1.23
Architectures: windows-amd64
-GitCommit: 01dc540d7fbab91ada1a5ec0ae6a215ab734de31
+GitCommit: 0f7ef098851cca2bad10b356ebbcecc7b83f6f56
Directory: 1.23/windows/windowsservercore-ltsc2025
Builder: classic
Constraints: windowsservercore-ltsc2025
@@ -119,7 +119,7 @@ Constraints: nanoserver-ltsc2025, windowsservercore-ltsc2025
Tags: 1.24.1-windowsservercore-1809, 1.24-windowsservercore-1809, 1-windowsservercore-1809, windowsservercore-1809
SharedTags: 1.24.1-windowsservercore, 1.24-windowsservercore, 1-windowsservercore, windowsservercore, 1.24.1, 1.24, 1, latest
Architectures: windows-amd64
-GitCommit: 7ba64590f6cd1268b3604329ac28e5fd7400ca79
+GitCommit: 0f7ef098851cca2bad10b356ebbcecc7b83f6f56
Directory: 1.24/windows/windowsservercore-1809
Builder: classic
Constraints: windowsservercore-1809
@@ -127,7 +127,7 @@ Constraints: windowsservercore-1809
Tags: 1.24.1-windowsservercore-ltsc2022, 1.24-windowsservercore-ltsc2022, 1-windowsservercore-ltsc2022, windowsservercore-ltsc2022
SharedTags: 1.24.1-windowsservercore, 1.24-windowsservercore, 1-windowsservercore, windowsservercore, 1.24.1, 1.24, 1, latest
Architectures: windows-amd64
-GitCommit: 7ba64590f6cd1268b3604329ac28e5fd7400ca79
+GitCommit: 0f7ef098851cca2bad10b356ebbcecc7b83f6f56
Directory: 1.24/windows/windowsservercore-ltsc2022
Builder: classic
Constraints: windowsservercore-ltsc2022
@@ -135,7 +135,7 @@ Constraints: windowsservercore-ltsc2022
Tags: 1.24.1-windowsservercore-ltsc2025, 1.24-windowsservercore-ltsc2025, 1-windowsservercore-ltsc2025, windowsservercore-ltsc2025
SharedTags: 1.24.1-windowsservercore, 1.24-windowsservercore, 1-windowsservercore, windowsservercore, 1.24.1, 1.24, 1, latest
Architectures: windows-amd64
-GitCommit: 7ba64590f6cd1268b3604329ac28e5fd7400ca79
+GitCommit: 0f7ef098851cca2bad10b356ebbcecc7b83f6f56
Directory: 1.24/windows/windowsservercore-ltsc2025
Builder: classic
Constraints: windowsservercore-ltsc2025
diff --git a/golang_1.23-windowsservercore-1809/Dockerfile b/golang_1.23-windowsservercore-1809/Dockerfile
index e5f5a0b..994ec9b 100644
--- a/golang_1.23-windowsservercore-1809/Dockerfile
+++ b/golang_1.23-windowsservercore-1809/Dockerfile
@@ -10,13 +10,14 @@ FROM mcr.microsoft.com/windows/servercore:1809
SHELL ["powershell", "-Command", "$ErrorActionPreference = 'Stop'; $ProgressPreference = 'SilentlyContinue';"]
# install MinGit (especially for "go get")
-# https://blogs.msdn.microsoft.com/visualstudioalm/2016/09/03/whats-new-in-git-for-windows-2-10/
-# "Essentially, it is a Git for Windows that was stripped down as much as possible without sacrificing the functionality in which 3rd-party software may be interested."
-# "It currently requires only ~45MB on disk."
-ENV GIT_VERSION 2.23.0
+# https://github.com/git-for-windows/git/wiki/MinGit
+# https://gitforwindows.org/
+# https://github.com/git-for-windows/git/releases
+# TODO in some future release, consider the BusyBox variant? maybe only once https://github.com/git-for-windows/git/issues/1439 is officially closed?
+ENV GIT_VERSION 2.48.1
ENV GIT_TAG v${GIT_VERSION}.windows.1
ENV GIT_DOWNLOAD_URL https://github.com/git-for-windows/git/releases/download/${GIT_TAG}/MinGit-${GIT_VERSION}-64-bit.zip
-ENV GIT_DOWNLOAD_SHA256 8f65208f92c0b4c3ae4c0cf02d4b5f6791d539cd1a07b2df62b7116467724735
+ENV GIT_DOWNLOAD_SHA256 11e8f462726827acccc7ecdad541f2544cbe5506d70fef4fa1ffac7c16288709
# steps inspired by "chcolateyInstall.ps1" from "git.install" (https://chocolatey.org/packages/git.install)
RUN Write-Host ('Downloading {0} ...' -f $env:GIT_DOWNLOAD_URL); \
[Net.ServicePointManager]::SecurityProtocol = [Net.SecurityProtocolType]::Tls12; \
@@ -42,6 +43,9 @@ RUN Write-Host ('Downloading {0} ...' -f $env:GIT_DOWNLOAD_URL); \
git version; \
\
Write-Host 'Complete.';
+# https://blogs.msdn.microsoft.com/visualstudioalm/2016/09/03/whats-new-in-git-for-windows-2-10/
+# "Essentially, it is a Git for Windows that was stripped down as much as possible without sacrificing the functionality in which 3rd-party software may be interested."
+# "It currently requires only ~45MB on disk."
# for 1.17+, we'll follow the (new) Go upstream default for install (https://golang.org/cl/283600), which frees up C:\go to be the default GOPATH and thus match the Linux images more closely (https://github.com/docker-library/golang/issues/288)
ENV GOPATH C:\\go
diff --git a/golang_1.23-windowsservercore-ltsc2022/Dockerfile b/golang_1.23-windowsservercore-ltsc2022/Dockerfile
index 8406422..8ed9ffd 100644
--- a/golang_1.23-windowsservercore-ltsc2022/Dockerfile
+++ b/golang_1.23-windowsservercore-ltsc2022/Dockerfile
@@ -10,13 +10,14 @@ FROM mcr.microsoft.com/windows/servercore:ltsc2022
SHELL ["powershell", "-Command", "$ErrorActionPreference = 'Stop'; $ProgressPreference = 'SilentlyContinue';"]
# install MinGit (especially for "go get")
-# https://blogs.msdn.microsoft.com/visualstudioalm/2016/09/03/whats-new-in-git-for-windows-2-10/
-# "Essentially, it is a Git for Windows that was stripped down as much as possible without sacrificing the functionality in which 3rd-party software may be interested."
-# "It currently requires only ~45MB on disk."
-ENV GIT_VERSION 2.23.0
+# https://github.com/git-for-windows/git/wiki/MinGit
+# https://gitforwindows.org/
+# https://github.com/git-for-windows/git/releases
+# TODO in some future release, consider the BusyBox variant? maybe only once https://github.com/git-for-windows/git/issues/1439 is officially closed?
+ENV GIT_VERSION 2.48.1
ENV GIT_TAG v${GIT_VERSION}.windows.1
ENV GIT_DOWNLOAD_URL https://github.com/git-for-windows/git/releases/download/${GIT_TAG}/MinGit-${GIT_VERSION}-64-bit.zip
-ENV GIT_DOWNLOAD_SHA256 8f65208f92c0b4c3ae4c0cf02d4b5f6791d539cd1a07b2df62b7116467724735
+ENV GIT_DOWNLOAD_SHA256 11e8f462726827acccc7ecdad541f2544cbe5506d70fef4fa1ffac7c16288709
# steps inspired by "chcolateyInstall.ps1" from "git.install" (https://chocolatey.org/packages/git.install)
RUN Write-Host ('Downloading {0} ...' -f $env:GIT_DOWNLOAD_URL); \
[Net.ServicePointManager]::SecurityProtocol = [Net.SecurityProtocolType]::Tls12; \
@@ -42,6 +43,9 @@ RUN Write-Host ('Downloading {0} ...' -f $env:GIT_DOWNLOAD_URL); \
git version; \
\
Write-Host 'Complete.';
+# https://blogs.msdn.microsoft.com/visualstudioalm/2016/09/03/whats-new-in-git-for-windows-2-10/
+# "Essentially, it is a Git for Windows that was stripped down as much as possible without sacrificing the functionality in which 3rd-party software may be interested."
+# "It currently requires only ~45MB on disk."
# for 1.17+, we'll follow the (new) Go upstream default for install (https://golang.org/cl/283600), which frees up C:\go to be the default GOPATH and thus match the Linux images more closely (https://github.com/docker-library/golang/issues/288)
ENV GOPATH C:\\go
diff --git a/golang_1.23-windowsservercore-ltsc2025/Dockerfile b/golang_1.23-windowsservercore-ltsc2025/Dockerfile
index 7c149cd..0e00ebd 100644
--- a/golang_1.23-windowsservercore-ltsc2025/Dockerfile
+++ b/golang_1.23-windowsservercore-ltsc2025/Dockerfile
@@ -10,13 +10,14 @@ FROM mcr.microsoft.com/windows/servercore:ltsc2025
SHELL ["powershell", "-Command", "$ErrorActionPreference = 'Stop'; $ProgressPreference = 'SilentlyContinue';"]
# install MinGit (especially for "go get")
-# https://blogs.msdn.microsoft.com/visualstudioalm/2016/09/03/whats-new-in-git-for-windows-2-10/
-# "Essentially, it is a Git for Windows that was stripped down as much as possible without sacrificing the functionality in which 3rd-party software may be interested."
-# "It currently requires only ~45MB on disk."
-ENV GIT_VERSION 2.23.0
+# https://github.com/git-for-windows/git/wiki/MinGit
+# https://gitforwindows.org/
+# https://github.com/git-for-windows/git/releases
+# TODO in some future release, consider the BusyBox variant? maybe only once https://github.com/git-for-windows/git/issues/1439 is officially closed?
+ENV GIT_VERSION 2.48.1
ENV GIT_TAG v${GIT_VERSION}.windows.1
ENV GIT_DOWNLOAD_URL https://github.com/git-for-windows/git/releases/download/${GIT_TAG}/MinGit-${GIT_VERSION}-64-bit.zip
-ENV GIT_DOWNLOAD_SHA256 8f65208f92c0b4c3ae4c0cf02d4b5f6791d539cd1a07b2df62b7116467724735
+ENV GIT_DOWNLOAD_SHA256 11e8f462726827acccc7ecdad541f2544cbe5506d70fef4fa1ffac7c16288709
# steps inspired by "chcolateyInstall.ps1" from "git.install" (https://chocolatey.org/packages/git.install)
RUN Write-Host ('Downloading {0} ...' -f $env:GIT_DOWNLOAD_URL); \
[Net.ServicePointManager]::SecurityProtocol = [Net.SecurityProtocolType]::Tls12; \
@@ -42,6 +43,9 @@ RUN Write-Host ('Downloading {0} ...' -f $env:GIT_DOWNLOAD_URL); \
git version; \
\
Write-Host 'Complete.';
+# https://blogs.msdn.microsoft.com/visualstudioalm/2016/09/03/whats-new-in-git-for-windows-2-10/
+# "Essentially, it is a Git for Windows that was stripped down as much as possible without sacrificing the functionality in which 3rd-party software may be interested."
+# "It currently requires only ~45MB on disk."
# for 1.17+, we'll follow the (new) Go upstream default for install (https://golang.org/cl/283600), which frees up C:\go to be the default GOPATH and thus match the Linux images more closely (https://github.com/docker-library/golang/issues/288)
ENV GOPATH C:\\go
diff --git a/golang_windowsservercore-1809/Dockerfile b/golang_windowsservercore-1809/Dockerfile
index a0d4e93..7ba9912 100644
--- a/golang_windowsservercore-1809/Dockerfile
+++ b/golang_windowsservercore-1809/Dockerfile
@@ -10,13 +10,14 @@ FROM mcr.microsoft.com/windows/servercore:1809
SHELL ["powershell", "-Command", "$ErrorActionPreference = 'Stop'; $ProgressPreference = 'SilentlyContinue';"]
# install MinGit (especially for "go get")
-# https://blogs.msdn.microsoft.com/visualstudioalm/2016/09/03/whats-new-in-git-for-windows-2-10/
-# "Essentially, it is a Git for Windows that was stripped down as much as possible without sacrificing the functionality in which 3rd-party software may be interested."
-# "It currently requires only ~45MB on disk."
-ENV GIT_VERSION 2.23.0
+# https://github.com/git-for-windows/git/wiki/MinGit
+# https://gitforwindows.org/
+# https://github.com/git-for-windows/git/releases
+# TODO in some future release, consider the BusyBox variant? maybe only once https://github.com/git-for-windows/git/issues/1439 is officially closed?
+ENV GIT_VERSION 2.48.1
ENV GIT_TAG v${GIT_VERSION}.windows.1
ENV GIT_DOWNLOAD_URL https://github.com/git-for-windows/git/releases/download/${GIT_TAG}/MinGit-${GIT_VERSION}-64-bit.zip
-ENV GIT_DOWNLOAD_SHA256 8f65208f92c0b4c3ae4c0cf02d4b5f6791d539cd1a07b2df62b7116467724735
+ENV GIT_DOWNLOAD_SHA256 11e8f462726827acccc7ecdad541f2544cbe5506d70fef4fa1ffac7c16288709
# steps inspired by "chcolateyInstall.ps1" from "git.install" (https://chocolatey.org/packages/git.install)
RUN Write-Host ('Downloading {0} ...' -f $env:GIT_DOWNLOAD_URL); \
[Net.ServicePointManager]::SecurityProtocol = [Net.SecurityProtocolType]::Tls12; \
@@ -42,6 +43,9 @@ RUN Write-Host ('Downloading {0} ...' -f $env:GIT_DOWNLOAD_URL); \
git version; \
\
Write-Host 'Complete.';
+# https://blogs.msdn.microsoft.com/visualstudioalm/2016/09/03/whats-new-in-git-for-windows-2-10/
+# "Essentially, it is a Git for Windows that was stripped down as much as possible without sacrificing the functionality in which 3rd-party software may be interested."
+# "It currently requires only ~45MB on disk."
# for 1.17+, we'll follow the (new) Go upstream default for install (https://golang.org/cl/283600), which frees up C:\go to be the default GOPATH and thus match the Linux images more closely (https://github.com/docker-library/golang/issues/288)
ENV GOPATH C:\\go
diff --git a/golang_windowsservercore-ltsc2022/Dockerfile b/golang_windowsservercore-ltsc2022/Dockerfile
index 172b3bf..4ea988f 100644
--- a/golang_windowsservercore-ltsc2022/Dockerfile
+++ b/golang_windowsservercore-ltsc2022/Dockerfile
@@ -10,13 +10,14 @@ FROM mcr.microsoft.com/windows/servercore:ltsc2022
SHELL ["powershell", "-Command", "$ErrorActionPreference = 'Stop'; $ProgressPreference = 'SilentlyContinue';"]
# install MinGit (especially for "go get")
-# https://blogs.msdn.microsoft.com/visualstudioalm/2016/09/03/whats-new-in-git-for-windows-2-10/
-# "Essentially, it is a Git for Windows that was stripped down as much as possible without sacrificing the functionality in which 3rd-party software may be interested."
-# "It currently requires only ~45MB on disk."
-ENV GIT_VERSION 2.23.0
+# https://github.com/git-for-windows/git/wiki/MinGit
+# https://gitforwindows.org/
+# https://github.com/git-for-windows/git/releases
+# TODO in some future release, consider the BusyBox variant? maybe only once https://github.com/git-for-windows/git/issues/1439 is officially closed?
+ENV GIT_VERSION 2.48.1
ENV GIT_TAG v${GIT_VERSION}.windows.1
ENV GIT_DOWNLOAD_URL https://github.com/git-for-windows/git/releases/download/${GIT_TAG}/MinGit-${GIT_VERSION}-64-bit.zip
-ENV GIT_DOWNLOAD_SHA256 8f65208f92c0b4c3ae4c0cf02d4b5f6791d539cd1a07b2df62b7116467724735
+ENV GIT_DOWNLOAD_SHA256 11e8f462726827acccc7ecdad541f2544cbe5506d70fef4fa1ffac7c16288709
# steps inspired by "chcolateyInstall.ps1" from "git.install" (https://chocolatey.org/packages/git.install)
RUN Write-Host ('Downloading {0} ...' -f $env:GIT_DOWNLOAD_URL); \
[Net.ServicePointManager]::SecurityProtocol = [Net.SecurityProtocolType]::Tls12; \
@@ -42,6 +43,9 @@ RUN Write-Host ('Downloading {0} ...' -f $env:GIT_DOWNLOAD_URL); \
git version; \
\
Write-Host 'Complete.';
+# https://blogs.msdn.microsoft.com/visualstudioalm/2016/09/03/whats-new-in-git-for-windows-2-10/
+# "Essentially, it is a Git for Windows that was stripped down as much as possible without sacrificing the functionality in which 3rd-party software may be interested."
+# "It currently requires only ~45MB on disk."
# for 1.17+, we'll follow the (new) Go upstream default for install (https://golang.org/cl/283600), which frees up C:\go to be the default GOPATH and thus match the Linux images more closely (https://github.com/docker-library/golang/issues/288)
ENV GOPATH C:\\go
diff --git a/golang_windowsservercore-ltsc2025/Dockerfile b/golang_windowsservercore-ltsc2025/Dockerfile
index a67b20a..0ad3bc5 100644
--- a/golang_windowsservercore-ltsc2025/Dockerfile
+++ b/golang_windowsservercore-ltsc2025/Dockerfile
@@ -10,13 +10,14 @@ FROM mcr.microsoft.com/windows/servercore:ltsc2025
SHELL ["powershell", "-Command", "$ErrorActionPreference = 'Stop'; $ProgressPreference = 'SilentlyContinue';"]
# install MinGit (especially for "go get")
-# https://blogs.msdn.microsoft.com/visualstudioalm/2016/09/03/whats-new-in-git-for-windows-2-10/
-# "Essentially, it is a Git for Windows that was stripped down as much as possible without sacrificing the functionality in which 3rd-party software may be interested."
-# "It currently requires only ~45MB on disk."
-ENV GIT_VERSION 2.23.0
+# https://github.com/git-for-windows/git/wiki/MinGit
+# https://gitforwindows.org/
+# https://github.com/git-for-windows/git/releases
+# TODO in some future release, consider the BusyBox variant? maybe only once https://github.com/git-for-windows/git/issues/1439 is officially closed?
+ENV GIT_VERSION 2.48.1
ENV GIT_TAG v${GIT_VERSION}.windows.1
ENV GIT_DOWNLOAD_URL https://github.com/git-for-windows/git/releases/download/${GIT_TAG}/MinGit-${GIT_VERSION}-64-bit.zip
-ENV GIT_DOWNLOAD_SHA256 8f65208f92c0b4c3ae4c0cf02d4b5f6791d539cd1a07b2df62b7116467724735
+ENV GIT_DOWNLOAD_SHA256 11e8f462726827acccc7ecdad541f2544cbe5506d70fef4fa1ffac7c16288709
# steps inspired by "chcolateyInstall.ps1" from "git.install" (https://chocolatey.org/packages/git.install)
RUN Write-Host ('Downloading {0} ...' -f $env:GIT_DOWNLOAD_URL); \
[Net.ServicePointManager]::SecurityProtocol = [Net.SecurityProtocolType]::Tls12; \
@@ -42,6 +43,9 @@ RUN Write-Host ('Downloading {0} ...' -f $env:GIT_DOWNLOAD_URL); \
git version; \
\
Write-Host 'Complete.';
+# https://blogs.msdn.microsoft.com/visualstudioalm/2016/09/03/whats-new-in-git-for-windows-2-10/
+# "Essentially, it is a Git for Windows that was stripped down as much as possible without sacrificing the functionality in which 3rd-party software may be interested."
+# "It currently requires only ~45MB on disk."
# for 1.17+, we'll follow the (new) Go upstream default for install (https://golang.org/cl/283600), which frees up C:\go to be the default GOPATH and thus match the Linux images more closely (https://github.com/docker-library/golang/issues/288)
ENV GOPATH C:\\goRelevant Maintainers: |
yosifkit
approved these changes
Mar 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes: