Skip to content

Add tests for phpMyAdmin #9046

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
J0WI wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add tests for phpMyAdmin #9046

J0WI wants to merge 1 commit into from

Conversation

@J0WI
Copy link
Contributor

@J0WI J0WI commented Nov 8, 2020

@J0WI J0WI mentioned this pull request Nov 9, 2020
Merged
@tianon
Copy link
Member

tianon commented Nov 10, 2020

I'm a bit confused -- this (especially test/tests/phpmyadmin-apache-run/world.sql 😱) seems kind of large/intensive for a basic smoke test?

If phpmyadmin/docker#313 is the motivation for this, I'd suggest something like https://github.com/tianon/dockerfiles/blob/bb3600a7b4027e9c74f63215a4d85398c657b73f/.github/workflows/generate.sh#L42-L48 in order to provide an additional config.sh, which should allow additional tests to live in that repo directly. (Alternatively, have that CI add to the prepare step to inject some contents into ~/oi/test/tests/ and append to ~/oi/test/config.sh directly, if that feels easier to maintain than an admittedly unsightly regex.)

@J0WI
Copy link
Contributor Author

J0WI commented Nov 15, 2020

I'm a bit confused -- this (especially test/tests/phpmyadmin-apache-run/world.sql scream) seems kind of large/intensive for a basic smoke test?

True, I just moved the existing tests. I guess I could easily reduce it.

Is there any documentation for config.sh?

@williamdes
Copy link
Contributor

williamdes commented Nov 15, 2020

True, I just moved the existing tests. I guess I could easily reduce it.

You can go ahead 👍 , I will be ready to merge your work

@J0WI J0WI force-pushed the phpmyadmin-tests branch from d24848c to 0d33d9a Compare December 3, 2022 22:58
williamdes
williamdes reviewed Dec 4, 2022
View reviewed changes
test/tests/phpmyadmin-apache-run/phpmyadmin_test.py
def do_test_content(match, content):
assert(match in content)

def test_phpmyadmin(url, username, password, server, sqlfile):
Copy link
Contributor

@williamdes williamdes Dec 4, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I recently pushed more changes upstream
And started to try to plug them in on our CI
But the having to start a mysql server blocked me

I think you can pick my changes on the py test script :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@williamdes williamdes williamdes approved these changes

Reviewers whose approvals may not affect merge requirements

At least 0 approving reviews are required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@J0WI @tianon @williamdes