Skip to content

bake: deprecate x-bake compose extension #3025

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

crazy-max
Copy link
Member

#721 was introduced to allow the use of additional fields that were not supported by the official specification at the time. Now that the Compose specification for build is ahead, we can deprecate this extension and eventually remove it in a future release.

Note that no-cache-filter and output are not yet supported by the official specification.

Copy link
Contributor

@glours glours left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@crazy-max crazy-max marked this pull request as ready for review February 25, 2025 16:54
@tonistiigi
Copy link
Member

tonistiigi commented Feb 25, 2025

I don't get this. Is this expecting that bake will never add new fields in the definition? Plus, there are many fields in bake definition not supported in compose build block.

@crazy-max
Copy link
Member Author

Is this expecting that bake will never add new fields in the definition? Plus, there are many fields in bake definition not supported in compose build block.

No it just means that the official compose specification needs to add new fields to build block. x-bake was meaningful when there was no parity between bake fields and the official spec at the time.

Only missing fields from the official spec that are supported today in x-bake extension are no-cache-filter and output. We can postpone deprecation until these fields made into the official spec.

@crazy-max crazy-max modified the milestones: v0.22.0, v0.23.0 Mar 7, 2025
@crazy-max crazy-max modified the milestones: v0.23.0, v0.future Mar 27, 2025
@crazy-max crazy-max self-assigned this Apr 3, 2025
@crazy-max
Copy link
Member Author

Put this one in draft until missing fields are supported by the compose spec.

@crazy-max crazy-max marked this pull request as draft April 7, 2025 12:07
@thompson-shaun thompson-shaun modified the milestones: v0.future, v0.24.0 Apr 7, 2025
@crazy-max crazy-max removed this from the v0.24.0 milestone Apr 14, 2025
@thompson-shaun
Copy link
Collaborator

We'll need to replace this PR with another that uses the warning path

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants