Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cli/command/plugin: runCreate: minor cleanup #5729

Merged
merged 1 commit into from
Jan 8, 2025

Conversation

thaJeztah
Copy link
Member

had this stashed locally

- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)

@thaJeztah thaJeztah added status/2-code-review kind/refactor PR's that refactor, or clean-up code labels Jan 8, 2025
@thaJeztah thaJeztah added this to the 28.0.0 milestone Jan 8, 2025
@thaJeztah thaJeztah self-assigned this Jan 8, 2025
@codecov-commenter
Copy link

codecov-commenter commented Jan 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.51%. Comparing base (667ece3) to head (bf2dae2).
Report is 5 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5729      +/-   ##
==========================================
+ Coverage   59.13%   59.51%   +0.37%     
==========================================
  Files         343      346       +3     
  Lines       29370    29376       +6     
==========================================
+ Hits        17369    17483     +114     
+ Misses      11029    10923     -106     
+ Partials      972      970       -2     

Copy link
Collaborator

@laurazard laurazard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thaJeztah thaJeztah merged commit ff4697d into docker:master Jan 8, 2025
101 checks passed
@thaJeztah thaJeztah deleted the cleanup_plugin_install branch January 8, 2025 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/refactor PR's that refactor, or clean-up code status/2-code-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants