Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vendor: github.com/spf13/cobra v1.9.1 #5829

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

thaJeztah
Copy link
Member

@thaJeztah thaJeztah commented Feb 16, 2025

vendor: github.com/spf13/cobra v1.9.1

full diff: spf13/cobra@v1.8.1...v1.9.1

- What I did

- How I did it

- How to verify it

- Human readable description for the release notes

- A picture of a cute animal (not mandatory but encouraged)

@codecov-commenter
Copy link

codecov-commenter commented Feb 16, 2025

Codecov Report

Attention: Patch coverage is 75.00000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 59.33%. Comparing base (2d74733) to head (8dfc0e0).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5829   +/-   ##
=======================================
  Coverage   59.33%   59.33%           
=======================================
  Files         358      358           
  Lines       29783    29783           
=======================================
  Hits        17672    17672           
  Misses      11142    11142           
  Partials      969      969           
🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@thaJeztah thaJeztah changed the title [WIP] vendor: github.com/spf13/cobra main (v1.9.1) vendor: github.com/spf13/cobra v1.9.1 Feb 17, 2025
@thaJeztah thaJeztah self-assigned this Feb 17, 2025
@thaJeztah
Copy link
Member Author

FWIW; keeping this in draft, because docker/cli is a dependency of buildx, and I don't want to force it to update to latest cobra this late in the release; we can consider it for a minor release or next major release though.

Cobra now defines a CompletionFunc for the same, so we can alias
it to that, and stop using our own definition.

Signed-off-by: Sebastiaan van Stijn <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants