Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/dockerd: use stdlib errors #5939

Merged
merged 1 commit into from
Mar 20, 2025

Conversation

thaJeztah
Copy link
Member

This package is not imported externally, and we don't need the added functionality of pkg/errors here, so use stdlib errors.

- Human readable description for the release notes

- A picture of a cute animal (not mandatory but encouraged)

@thaJeztah thaJeztah added status/2-code-review kind/refactor PR's that refactor, or clean-up code labels Mar 19, 2025
@thaJeztah
Copy link
Member Author

derp; missed one

This package is not imported externally, and we don't need the added
functionality of pkg/errors here, so use stdlib errors.

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah thaJeztah force-pushed the cmd_dockerd_stdlib_errs branch from 121b2c9 to 082dfb7 Compare March 19, 2025 13:06
@codecov-commenter
Copy link

codecov-commenter commented Mar 19, 2025

Codecov Report

Attention: Patch coverage is 22.22222% with 7 lines in your changes missing coverage. Please review.

Project coverage is 59.29%. Comparing base (0f75059) to head (082dfb7).
Report is 23 commits behind head on master.

❌ Your patch status has failed because the patch coverage (22.22%) is below the target coverage (50.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5939      +/-   ##
==========================================
+ Coverage   58.90%   59.29%   +0.38%     
==========================================
  Files         355      358       +3     
  Lines       29819    29827       +8     
==========================================
+ Hits        17566    17685     +119     
+ Misses      11279    11171     -108     
+ Partials      974      971       -3     
🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@thaJeztah thaJeztah added this to the 28.0.3 milestone Mar 20, 2025
@thaJeztah thaJeztah merged commit b199ece into docker:master Mar 20, 2025
87 checks passed
@thaJeztah thaJeztah deleted the cmd_dockerd_stdlib_errs branch March 20, 2025 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/refactor PR's that refactor, or clean-up code status/2-code-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants