-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bump golang.org/x/net to v0.33.0 to fix potential security issue #12405
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
golang/go#70906 Signed-off-by: Guillaume Lours <705411+glours@users.noreply.github.com>
Just to prevent people from being concerned; this is fixing potential false positives from scanners. The docker compose code is NOT affected by this CVE; git rev-parse --verify HEAD
56e92e34b63739ae345453a96fd315c8d8b06e93
go install golang.org/x/vuln/cmd/govulncheck@latest
govulncheck -show=verbose ./...
Scanning your code and 1172 packages across 179 dependent modules for known vulnerabilities...
Fetching vulnerabilities from the database...
Checking the code against the vulnerabilities...
=== Symbol Results ===
No vulnerabilities found.
=== Package Results ===
Vulnerability #1: GO-2024-3333
Non-linear parsing of case-insensitive content in golang.org/x/net/html
More info: https://pkg.go.dev/vuln/GO-2024-3333
Module: golang.org/x/net
Found in: golang.org/x/net@v0.29.0
Fixed in: golang.org/x/net@v0.33.0
=== Module Results ===
No other vulnerabilities found.
Your code is affected by 0 vulnerabilities.
This scan also found 1 vulnerability in packages you import and 0
vulnerabilities in modules you require, but your code doesn't appear to call
these vulnerabilities.
|
thaJeztah
approved these changes
Dec 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
ndeloof
approved these changes
Jan 7, 2025
tmeijn
pushed a commit
to tmeijn/dotfiles
that referenced
this pull request
Jan 8, 2025
This MR contains the following updates: | Package | Update | Change | |---|---|---| | [docker/compose](https://github.com/docker/compose) | patch | `v2.32.1` -> `v2.32.2` | MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot). **Proposed changes to behavior should be submitted there as MRs.** --- ### Release Notes <details> <summary>docker/compose (docker/compose)</summary> ### [`v2.32.2`](https://github.com/docker/compose/releases/tag/v2.32.2) [Compare Source](docker/compose@v2.32.1...v2.32.2) #### What's Changed ##### ✨ Improvements - Add `--pull` to run command by [@​glours](https://github.com/glours) [(12397)](docker/compose#12397) ##### 🐛 Fixes - Only check bind mount conflict if sync action is involved by [@​ndeloof](https://github.com/ndeloof) [(12409)](docker/compose#12409) - When retrying to resolveOrCreateNetwork, retry with a valid network name by [@​gtardif](https://github.com/gtardif) [(12422)](docker/compose#12422) - checkExpectedVolumes must ignore anonymous volumes by [@​ndeloof](https://github.com/ndeloof) in docker/compose#12410 ##### 🔧 Internal - Gofumpt all the things by [@​ndeloof](https://github.com/ndeloof) [(12392)](docker/compose#12392) - Use the 3 latest major versions of the engine to run e2e step by [@​glours](https://github.com/glours) [(12401)](docker/compose#12401) - Replace tibdex/github-app-token by official GitHub create-github-app-token by [@​glours](https://github.com/glours) [(12411)](docker/compose#12411) ##### ⚙️ Dependencies - Bump Golang version to `v1.22.10` and update CI actions by [@​glours](https://github.com/glours) [(12399)](docker/compose#12399) - Bump golang.org/x/net to `v0.33.0` to fix potential security issue by [@​glours](https://github.com/glours) [(12405)](docker/compose#12405) - Bump `compose-go` to `v2.4.7` by [@​glours](https://github.com/glours) [(12438)](docker/compose#12438) **Full Changelog**: docker/compose@v2.32.1...v2.32.2 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever MR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this MR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box --- This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOS45MS40IiwidXBkYXRlZEluVmVyIjoiMzkuOTEuNCIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsiUmVub3ZhdGUgQm90Il19-->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
golang/go#70906
What I did
update golang.org/x/net dependency to version
v0.33.0
Related issue
(not mandatory) A picture of a cute animal, if possible in relation to what you did