Prevent target block attributes from being reused in other blocks #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have a lot of support for textDocument/definition requests for attributes within a target block. Some of them assumed that these attributes would only ever be found on a target block so if they were replicated inside a different block (such as group or variable) then the textDocument/definition request would still get results back. Additional checks have now been introduced to ensure that we only respond to those requests if they were sent for a position inside a target block. Signed-off-by: Remy Suen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have a lot of support for
textDocument/definitionrequests for attributes within a target block. Some of them assumed that these attributes would only ever be found on a target block so if they were replicated inside a different block (such as group or variable) then thetextDocument/definitionrequest would still get results back.Additional checks have now been introduced to ensure that we only respond to those requests if they were sent for a position inside a target block.