Skip to content

Handle single quotes correctly for document links in Compose #494

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rcjsuen merged 1 commit into from
Nov 21, 2025
Merged

Handle single quotes correctly for document links in Compose #494

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,8 @@ All notable changes to the Docker Language Server will be documented in this fil
- Compose
- textDocument/completion
- check the prefix string before trying to use it for looking up image tags ([#486](https://github.com/docker/docker-language-server/issues/486))
- textDocument/documentLink
- correct the link range if the string is wrapped in single quotes ([#487](https://github.com/docker/docker-language-server/issues/487))
- Bake
- fix parsing error caused by referencing a variable with no value ([#490](https://github.com/docker/docker-language-server/issues/490))

Expand Down
2 changes: 1 addition & 1 deletion internal/compose/documentLink.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ import (

func createRange(t *token.Token, length int) protocol.Range {
offset := 0
if t.Type == token.DoubleQuoteType {
if t.Type == token.DoubleQuoteType || t.Type == token.SingleQuoteType {
offset = 1
}
return protocol.Range{
Expand Down
Loading
Loading