Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update all outdated callouts #21310

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

Update all outdated callouts #21310

wants to merge 10 commits into from
+238 −251

Conversation

sarahsanders-docker
Copy link
Contributor

@sarahsanders-docker sarahsanders-docker commented Oct 31, 2024 •
edited
Loading

Description

  • Did a search and replace for all outdated callout
  • Also did a little whitespace policing while I was at it 🚨

Related issues or tickets

ENGDOCS-2281

Reviews

  • Editorial review

@netlify Netlify
Copy link

netlify bot commented Oct 31, 2024 •
edited
Loading

✅ Deploy Preview for docsdocker ready!

Name Link
🔨 Latest commit 1d29f6c
🔍 Latest deploy log https://app.netlify.com/sites/docsdocker/deploys/6728feedb7a079000845054d
😎 Deploy Preview https://deploy-preview-21310--docsdocker.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added area/engine Issue affects Docker engine/daemon area/compose Relates to docker-compose.yml spec or docker-compose binary area/networking Relates to anything around networking area/swarm Issue affects swarm and clustering functionality of docker area/desktop Issue affects a desktop edition of Docker. E.g docker for mac area/security area/get-started Relates to get started and onboarding docs area/storage Relates to storage, volumes area/extensions Relates to Docker Extensions area/api Relates to Docker API docs labels Oct 31, 2024
@github-actions github-actions bot added area/hub Issue affects Docker Hub area/build Relates to Dockerfiles or docker build command hugo Updates related to hugo dependencies Vendoring, packaging updates labels Oct 31, 2024
@sarahsanders-docker sarahsanders-docker changed the title DRAFT: Update all outdated callouts Update all outdated callouts Oct 31, 2024
@sarahsanders-docker sarahsanders-docker marked this pull request as ready for review October 31, 2024 22:45
@sarahsanders-docker sarahsanders-docker requested review from a team and removed request for crazy-max, dvdksn, aevesdocker and craig-osterhout October 31, 2024 23:16
dvdksn
dvdksn previously requested changes Nov 1, 2024
View reviewed changes
Copy link
Collaborator

@dvdksn dvdksn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍 noticed some minor issues. Reviewing on my phone so I'm not sure I caught everything.

content/manuals/desktop/faqs/macfaqs.md Outdated Show resolved Hide resolved
content/manuals/desktop/previous-versions/edge-releases-windows.md Outdated Show resolved Hide resolved
content/manuals/desktop/previous-versions/edge-releases-windows.md Outdated Show resolved Hide resolved
content/manuals/docker-hub/builds/link-source.md Outdated Show resolved Hide resolved
content/manuals/engine/release-notes/17.03.md Outdated Show resolved Hide resolved
content/manuals/engine/storage/drivers/device-mapper-driver.md Outdated Show resolved Hide resolved
content/manuals/engine/swarm/how-swarm-mode-works/nodes.md Outdated Show resolved Hide resolved
@sarahsanders-docker @dvdksn
Update content/manuals/desktop/faqs/macfaqs.md
8f90383 
Co-authored-by: David Karlsson <[email protected]>
@sarahsanders-docker @dvdksn
Update content/manuals/desktop/previous-versions/edge-releases-window…
505f42b 
…s.md

Co-authored-by: David Karlsson <[email protected]>
@sarahsanders-docker @dvdksn
Update content/manuals/desktop/previous-versions/edge-releases-window…
efd8892 
…s.md

Co-authored-by: David Karlsson <[email protected]>
@sarahsanders-docker @dvdksn
Update content/manuals/docker-hub/builds/link-source.md
7dde8c7 
Co-authored-by: David Karlsson <[email protected]>
@sarahsanders-docker @dvdksn
Update content/manuals/engine/release-notes/17.03.md
1d903e2 
Co-authored-by: David Karlsson <[email protected]>
@sarahsanders-docker @dvdksn
Update content/manuals/engine/storage/drivers/device-mapper-driver.md
e9edb71 
Co-authored-by: David Karlsson <[email protected]>
@sarahsanders-docker @dvdksn
Update content/manuals/engine/swarm/how-swarm-mode-works/nodes.md
4bca81d 
Co-authored-by: David Karlsson <[email protected]>
@sarahsanders-docker
Update aci-ecs-eol.md
1d29f6c
@sarahsanders-docker sarahsanders-docker requested review from a team and dvdksn November 4, 2024 17:09
@sarahsanders-docker
Copy link
Contributor Author

@dvdksn I resolved all suggestions I think this PR just needs re-approval to go out

dvdksn
dvdksn approved these changes Nov 6, 2024
View reviewed changes
_vendor/github.com/moby/moby/docs/api/v1.24.md
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file is maintained upstream in moby/moby, so these changes would be overwritten the next time we update the vendored files unless we also make these changes upstream. Not a blocker, but just FYI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aevesdocker aevesdocker aevesdocker approved these changes

@dvdksn dvdksn dvdksn approved these changes

Assignees
No one assigned
Labels
area/api Relates to Docker API docs area/build Relates to Dockerfiles or docker build command area/compose Relates to docker-compose.yml spec or docker-compose binary area/desktop Issue affects a desktop edition of Docker. E.g docker for mac area/engine Issue affects Docker engine/daemon area/extensions Relates to Docker Extensions area/get-started Relates to get started and onboarding docs area/hub Issue affects Docker Hub area/networking Relates to anything around networking area/security area/storage Relates to storage, volumes area/swarm Issue affects swarm and clustering functionality of docker dependencies Vendoring, packaging updates hugo Updates related to hugo status/review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sarahsanders-docker @dvdksn @aevesdocker