Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement summary bars for feature attributes #21667

Open
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

sarahsanders-docker
Copy link
Contributor

@sarahsanders-docker sarahsanders-docker commented Dec 18, 2024

Description

  • Create summary-bar.html shortcode
  • Inline styling

Related issues or tickets

Reviews

  • Technical review
  • Editorial review
  • Product review

Preview: https://deploy-preview-21667--docsdocker.netlify.app/security/for-admins/hardened-desktop/settings-management/configure-admin-console/

@sarahsanders-docker sarahsanders-docker added the status/do-not-merge Pull requests that are awaiting some event or decision before they can be merged. label Dec 18, 2024
@github-actions github-actions bot added area/security hugo Updates related to hugo labels Dec 18, 2024
Copy link

netlify bot commented Dec 18, 2024

Deploy Preview for docsdocker ready!

Name Link
🔨 Latest commit 42471bf
🔍 Latest deploy log https://app.netlify.com/sites/docsdocker/deploys/6781764a9c40c50008d1b2f4
😎 Deploy Preview https://deploy-preview-21667--docsdocker.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@aevesdocker
Copy link
Contributor

aevesdocker commented Dec 19, 2024

This is looking really great @sarahsanders-docker. I have a few thinking-out-loud comments:

  • The blue banner is quite dominating. I wonder if it needs to blend in a tad more. Is there a lighter colour or perhaps, like the examples I added to the Notion page, we use lines to separate it 🤔
  • Is it clear that 'Business' means Business subscription? Is there a way we could use a hover-over tooltip that spells it out more fully? Or am I overthinking it
  • The order we display the info may need changing. "Available for: EA" for example, doesn't make sense. Perhaps we put life cycle info first, then 'Available for:....etc'?

@sarahsanders-docker sarahsanders-docker changed the title [WIP] summary bars implement summary bars for feature attributes Jan 10, 2025
@sarahsanders-docker sarahsanders-docker marked this pull request as ready for review January 10, 2025 19:44
@sarahsanders-docker sarahsanders-docker requested a review from a team January 10, 2025 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/security hugo Updates related to hugo status/do-not-merge Pull requests that are awaiting some event or decision before they can be merged. status/review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants