build: add manuals section about named contexts #21672
Open
+192
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: David Karlsson <[email protected]>
github-actions
bot
added
the
area/build
dvdksn
added
status/review
and removed
area/build
✅ Deploy Preview for docsdocker ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
crazy-max
reviewed
Jan 9, 2025
Comment on lines
+603
to
+605
| # syntax=docker/dockerfile:1 | ||
| FROM buildbase | ||
| WORKDIR /app |
There was a problem hiding this comment.
I think a nice pattern is to define src and docs as scratch otherwise it will not find the stage if no named context is defined:
Suggested change
| # syntax=docker/dockerfile:1 | |
| FROM buildbase | |
| WORKDIR /app | |
| # syntax=docker/dockerfile:1 | |
| FROM scratch AS src | |
| FROM scratch AS docs | |
| FROM buildbase | |
| WORKDIR /app |
I wonder if src as named context is necessary though. I think we could just have docs one as named context that would run make manpages only if /app/docs folder has files?
|
|
||
| - The context named `src` points to the `./src` directory on your local machine. | ||
| - The context named `docs` points to the `./docs` directory on your local machine. | ||
| - The `.` at the end specifies the default build context. |
There was a problem hiding this comment.
But default build context is not used in the dockerfile? From my previous comment we might just have docs as named context. Maybe I miss smth from your example.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a section on the build contexts page about named contexts.
Related issues or tickets