Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vscode tip #22297

Merged
merged 2 commits into from
Mar 26, 2025
Merged

vscode tip #22297

merged 2 commits into from
Mar 26, 2025

Conversation

aevesdocker
Copy link
Contributor

@aevesdocker aevesdocker commented Mar 24, 2025 •
edited
Loading

Description

Add VS Code callout to relevant pages within docs.
Can ignore vale issues.

https://docker.slack.com/archives/C06P7883JTD/p1742570070408109

Related issues or tickets

Reviews

  • Technical review
  • Editorial review
  • Product review

@aevesdocker aevesdocker requested a review from crazy-max as a code owner March 24, 2025 11:55
@github-actions github-actions bot added area/compose Relates to docker-compose.yml spec or docker-compose binary area/build Relates to Dockerfiles or docker build command labels Mar 24, 2025
@netlify Netlify
Copy link

netlify bot commented Mar 24, 2025 •
edited
Loading

✅ Deploy Preview for docsdocker ready!

Name Link
🔨 Latest commit 09dbd3f
🔍 Latest deploy log https://app.netlify.com/sites/docsdocker/deploys/67e412563b6b2700080c2db8
😎 Deploy Preview https://deploy-preview-22297--docsdocker.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@aevesdocker aevesdocker requested a review from a team March 24, 2025 11:59
@aevesdocker aevesdocker removed the request for review from a team March 24, 2025 12:03
@aevesdocker aevesdocker marked this pull request as draft March 24, 2025 12:03
aevesdocker
aevesdocker commented Mar 26, 2025
View reviewed changes
@aevesdocker aevesdocker marked this pull request as ready for review March 26, 2025 14:42
@aevesdocker aevesdocker requested a review from a team March 26, 2025 14:42
@aevesdocker aevesdocker enabled auto-merge March 26, 2025 14:45
sarahsanders-docker
sarahsanders-docker approved these changes Mar 26, 2025
View reviewed changes
Copy link
Collaborator

@sarahsanders-docker sarahsanders-docker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@aevesdocker aevesdocker merged commit e0b5866 into docker:main Mar 26, 2025
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sarahsanders-docker sarahsanders-docker sarahsanders-docker approved these changes

@crazy-max crazy-max Awaiting requested review from crazy-max crazy-max is a code owner

Assignees
No one assigned
Labels
area/build Relates to Dockerfiles or docker build command area/compose Relates to docker-compose.yml spec or docker-compose binary status/review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aevesdocker @sarahsanders-docker