Skip to content

add platform-split parameter #22753

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

ArthurFlag
Copy link
Contributor

Description

Parameter was missing.

Related issues or tickets

docker/buildx#3215 (comment)

Reviews

  • Technical review
  • Editorial review
  • Product review

@ArthurFlag ArthurFlag requested a review from crazy-max as a code owner June 3, 2025 09:13
Copy link

netlify bot commented Jun 3, 2025

Deploy Preview for docsdocker ready!

Name Link
🔨 Latest commit a093864
🔍 Latest deploy log https://app.netlify.com/projects/docsdocker/deploys/684154e57639260008b9894e
😎 Deploy Preview https://deploy-preview-22753--docsdocker.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions github-actions bot added the area/build Relates to Dockerfiles or docker build command label Jun 3, 2025
Copy link
Member

@crazy-max crazy-max left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we have some examples similar to ones in BuildKit README? https://github.com/moby/buildkit?tab=readme-ov-file#local-directory

Like https://docs.docker.com/build/exporters/image-registry/#annotations for image export annotations.

| Parameter | Type | Default | Description |
|------------------|---------|---------|---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------|
| `dest` | String | | Path to copy files to |
| `platform-split` | Boolean | `false` | With a multi-platform build, a subfolder matching each target platform is created in the destination directory. Set it to `true` to merge files from all platforms into the same directory. |
Copy link
Member

@crazy-max crazy-max Jun 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It defaults to true, not false. See example in https://github.com/moby/buildkit?tab=readme-ov-file#local-directory

Also with upcoming moby/buildkit#6007 and opting-in with true it would create the platform dir even if a single platform is being built. Which is not the case atm. So default should be nil in such case (not defined). cc @tonistiigi

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also this attribute is only supported by the local exporter.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated! Let's update the docs with this PR to document the current state of things, I'll update the docs again once the linked bk PR is merged.

@ArthurFlag ArthurFlag force-pushed the ENGDOCS-2685-add-platform-split-attribute branch from c9c7c8b to a093864 Compare June 5, 2025 08:27
@ArthurFlag ArthurFlag requested a review from crazy-max June 5, 2025 08:27
@ArthurFlag ArthurFlag merged commit 725e34e into docker:main Jun 6, 2025
14 checks passed
@ArthurFlag ArthurFlag deleted the ENGDOCS-2685-add-platform-split-attribute branch June 6, 2025 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/build Relates to Dockerfiles or docker build command area/tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants