-
Notifications
You must be signed in to change notification settings - Fork 7.7k
add platform-split
parameter
#22753
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add platform-split
parameter
#22753
Conversation
✅ Deploy Preview for docsdocker ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we have some examples similar to ones in BuildKit README? https://github.com/moby/buildkit?tab=readme-ov-file#local-directory
Like https://docs.docker.com/build/exporters/image-registry/#annotations for image export annotations.
| Parameter | Type | Default | Description | | ||
|------------------|---------|---------|---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------| | ||
| `dest` | String | | Path to copy files to | | ||
| `platform-split` | Boolean | `false` | With a multi-platform build, a subfolder matching each target platform is created in the destination directory. Set it to `true` to merge files from all platforms into the same directory. | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It defaults to true
, not false
. See example in https://github.com/moby/buildkit?tab=readme-ov-file#local-directory
Also with upcoming moby/buildkit#6007 and opting-in with true
it would create the platform dir even if a single platform is being built. Which is not the case atm. So default should be nil in such case (not defined). cc @tonistiigi
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also this attribute is only supported by the local
exporter.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated! Let's update the docs with this PR to document the current state of things, I'll update the docs again once the linked bk PR is merged.
c9c7c8b
to
a093864
Compare
Description
Parameter was missing.
Related issues or tickets
docker/buildx#3215 (comment)
Reviews