Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issues with mkcert addon #62

Closed
lmakarov opened this issue Apr 9, 2020 · 0 comments · Fixed by #63
Closed

Issues with mkcert addon #62

lmakarov opened this issue Apr 9, 2020 · 0 comments · Fixed by #63
Assignees
@achekulaev
Labels
bug

Comments

@lmakarov
Copy link
Member

lmakarov commented Apr 9, 2020 •
edited
Loading

TL;DR: to get this addon to work (for now), run the following in your project repo:

brew install mkcert
mkcert -install
fin addon install mkcert -g
fin mkcert create
fin project restart
  1. The addons does not install mkcert binary if it's not available (at least on Mac):
$ fin addon install mkcert -g
Downloading addon main script
  mkcert/mkcert
Addon mkcert was installed globally 

$ fin mkcert create
Could not create ssl certificates. Is mkcert still installed?

Workaround - install mkcert manually:

$ brew install mkcert
==> Downloading https://homebrew.bintray.com/bottles/mkcert-1.4.1.catalina.bottle.tar.gz
Already downloaded: /Users/leonid/Library/Caches/Homebrew/downloads/bbb16f3e4bb2c54bb63c2aa3d1b6d4d297d460b16f336decd95e4135d6243390--mkcert-1.4.1.catalina.bottle.tar.gz
==> Pouring mkcert-1.4.1.catalina.bottle.tar.gz
🍺  /usr/local/Cellar/mkcert/1.4.1: 6 files, 5.3MB

$ fin mkcert create
Created ssl certificates for myproject.docksal

$ fin project restart
...
  1. The addon does not automatically run nor prompts to run mkcert --install to get the mkcert CA installed in the system. You have to manually run it, otherwise the host system won't trust the certs generated with mkcert:
$ mkcert -install
Using the local CA at "/Users/leonid/Library/Application Support/mkcert" ✨
Sudo password:
The local CA is now installed in the system trust store! ⚡️
The local CA is now installed in the Firefox trust store (requires browser restart)! 🦊

cc @fjmk
@lmakarov lmakarov added the bug label Apr 9, 2020
@fjmk fjmk mentioned this issue Apr 27, 2020
Merged
lmakarov added a commit that referenced this issue Apr 27, 2020
@lmakarov
Merge pull request #63 from fjmk/feature/mkcert
a435e00 
Fix mkcert addon issues (#62)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@achekulaev achekulaev

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix mkcert addon issues (#62)
2 participants
@achekulaev @lmakarov