Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mkcert addon issues (#62) #63

Merged
merged 1 commit into from
Apr 27, 2020
Merged

Fix mkcert addon issues (#62) #63

merged 1 commit into from
Apr 27, 2020

Conversation

fjmk
Copy link
Contributor

@fjmk fjmk commented Apr 27, 2020

Fixes #62

  1. Changes
  • added file mkcert.filelist
  • error when global flag is not given
  • install mkcert binary when version is not current
  • better INFO/ERROR messages
  1. It runs sudo mkcert --install now. If installed before, you will see the message:

Using the local CA at "/home/frans/.local/share/mkcert" ✨
The local CA is already installed in the system trust store! 👍
The local CA is already installed in the Firefox and/or Chrome/Chromium trust store! 👍

Difficulty in testing addons is that fin is always using $URL_ADDONS_HOSTING/docksal/addons and the master branch. Maybe creating an overide for the repo & branch is an possibility to make it easier for addon development?

@fjmk
Copy link
Contributor Author

fjmk commented Apr 27, 2020

It is possible to test this on a system with a brew installed mkcert:
brew remove mkcert
brew cleanup
fin addon install mkcert -g

The mkcert binary is now installed in $HOME/.docksal/bin/mkcert

@lmakarov lmakarov self-requested a review April 27, 2020 20:09
@lmakarov lmakarov self-assigned this Apr 27, 2020
@lmakarov lmakarov changed the title solves mkcert addon issue #62 Fix mkcert addon issues (#62) Apr 27, 2020
@lmakarov lmakarov merged commit a435e00 into docksal:master Apr 27, 2020
@fjmk fjmk deleted the feature/mkcert branch April 28, 2020 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issues with mkcert addon
2 participants