Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pre install is blocked due to cli container up&running detection #85

Closed
philippemouchel opened this issue Jul 28, 2022 · 2 comments · Fixed by #86
Closed

Pre install is blocked due to cli container up&running detection #85

philippemouchel opened this issue Jul 28, 2022 · 2 comments · Fixed by #86

Comments

@philippemouchel
Copy link
Contributor

philippemouchel commented Jul 28, 2022 •
edited
Loading

For instance, in solr addon, but it's the same in all addons, the bas command to identify a running cli container is looking for Up, when it should be looking for running.

I'm using Docksal 1.17.0, fin 1.110.1 and running it on MacOS Monterey 12.5 (Intel chip) & Docker Desktop 4.10.1.

When I run a fin ps, here is what I can see:

$ fin ps
NAME            COMMAND                  SERVICE             STATUS              PORTS
project_cli_1   "/opt/startup.sh sup…"   cli                 running (healthy)   9000/tcp
project_db_1    "docker-entrypoint.s…"   db                  running (healthy)   0.0.0.0:52230->3306/tcp
project_web_1   "httpd-foreground"       web                 running (healthy)   443/tcp
@philippemouchel
Copy link
Contributor Author

It seems Disable feature is also impacted.
I'll provide a PR ASAP.

@philippemouchel
Copy link
Contributor Author

Pull-request #86 is available.

@lmakarov lmakarov mentioned this issue Mar 25, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

85: replace "Up" with "running" when checking for cli container state. philippemouchel/addons
2 participants
@lmakarov @philippemouchel