Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

85: replace "Up" with "running" when checking for cli container state. #86

Merged
merged 1 commit into from
Dec 9, 2022
Merged

85: replace "Up" with "running" when checking for cli container state. #86

merged 1 commit into from
Dec 9, 2022

Conversation

philippemouchel
Copy link
Contributor

@philippemouchel philippemouchel commented Jul 28, 2022 •
edited by lmakarov
Loading

Fixes #85

@philippemouchel philippemouchel changed the title 85: replace "Up" with "running" when checking for cli container state. #85: replace "Up" with "running" when checking for cli container state. Jul 28, 2022
@philippemouchel philippemouchel changed the title #85: replace "Up" with "running" when checking for cli container state. 85: replace "Up" with "running" when checking for cli container state. Jul 28, 2022
@philippemouchel philippemouchel mentioned this pull request Jul 28, 2022
Closed
@vistar
Copy link
Contributor

vistar commented Aug 18, 2022

PRs #83 and #82

@philippemouchel
Copy link
Contributor Author

philippemouchel commented Aug 18, 2022 •
edited
Loading

I saw this "Up" checking in several file, so I basically did a search/replace in the entire repo.
Both PRs you mention would be useless, as this one cover each case.

@achekulaev achekulaev merged commit aa30ff9 into docksal:master Dec 9, 2022
@KoalityJustin KoalityJustin mentioned this pull request Sep 13, 2023
Closed
shelane added a commit that referenced this pull request Mar 22, 2024
@shelane
Revert "85: replace "Up" with "running" when checking for cli contain…
c47ca7d 
…er state. (#86)"

This reverts commit aa30ff9.
@shelane shelane mentioned this pull request Mar 22, 2024
Merged
shelane added a commit that referenced this pull request Mar 22, 2024
@shelane
Revert "85: replace "Up" with "running" when checking for cli contain…
9c5aebb 
…er state. (#86)"

This reverts commit aa30ff9.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Pre install is blocked due to cli container up&running detection
3 participants
@philippemouchel @vistar @achekulaev