Fixes #56 for the MailHog addon …#58
Closed
frederickjh wants to merge 1 commit intodocksal:masterfrom
Closed
Conversation
…o "webmail". It appears that this has been for some time been overridden to the subdomain "mail" upstream in docksal/docksal in stacks/services.yml. This was changed in the upstream project from webmail to mail in version 1.7.0.
Contributor
Author
|
Sorry, This is already in MailHog. I forgot to pull in upstream before starting development. |
frederickjh
deleted the
feature/56-mailhog--standarize-domain-names-for-addons
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… using "mail" but it was set to "webmail". It appears that this has been for some time been overridden to the subdomain "mail" upstream in docksal/docksal in
stacks/services.yml. This was changed in the upstream project from webmail to mail in version 1.7.0.In order for the domain name to change for the MailHog addon this will need to change the label in docksal/docksal/
stacks/services.ymlon this line to:replacing the period with at dash.