Conversation
lmakarov
requested changes
Nov 10, 2020
Member
lmakarov
left a comment
lmakarov
left a comment
There was a problem hiding this comment.
Thanks for your contribution!
Please see the feedback inline.
sitediff/conf/sitediff.yml
Outdated
| - ${PROJECT_ROOT}/sitediff:/app/sitediff:cached | ||
| command: tail -f /dev/null | ||
| labels: | ||
| - io.docksal.virtual-host=sitediff.${VIRTUAL_HOST},mail.${VIRTUAL_HOST}.* |
Member
There was a problem hiding this comment.
Suggested change
| - io.docksal.virtual-host=sitediff.${VIRTUAL_HOST},mail.${VIRTUAL_HOST}.* | |
| - io.docksal.virtual-host=sitediff.${VIRTUAL_HOST},sitediff.${VIRTUAL_HOST}.* |
sitediff/sitediff
Outdated
| # Add sitediff service to docksal.yml | ||
| yml_add_service "$SITEDIFF_YML" | ||
| # Apply stack changes. | ||
| fin stop cli |
Member
There was a problem hiding this comment.
This does not seem necessary for this addon, since it does not change anything in the cli container.
sitediff/sitediff
Outdated
|
|
||
| #-------------------------------------- SITEDIFF functions --------------------------------------------- | ||
|
|
||
| # Set/remove proper setting into php.ini |
Member
There was a problem hiding this comment.
Update the comment to correctly reflect what's going on here.
sitediff/sitediff
Outdated
| # Remove sitediff service from docksal.yml | ||
| yml_remove_service "sitediff" | ||
| # Apply stack changes | ||
| COMPOSE_FILE="" fin stop cli |
Member
There was a problem hiding this comment.
Same here, this is likely not necessary.
Contributor
Author
|
@lmakarov thanks for the feedback. I just did the required fixes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
We're using docksal for our projects and I'd like to include this tool that we want to regularly use in our projects.
Thanks,