Merged
Conversation
shelane
requested changes
Mar 12, 2022
Member
shelane
left a comment
shelane
left a comment
There was a problem hiding this comment.
Some updated links and rewording of linking to the tools.
pull/README.md
Outdated
| # Remote Provider Pull | ||
|
|
||
| The `pull` addon was recently a core command but has been pulled out due as it is sometimes | ||
| quicker to get updates to just the addon as opposed to the whole platform. |
Member
There was a problem hiding this comment.
The pull addon was recently a core command but has been moved to an addon command.
|
|
||
| To interact with Acquia through Drush, the `SECRET_ACQUIA_CLI_SECRET` and | ||
| `SECRET_ACQUIA_CLI_KEY` are required. Additionally, access to the Acquia Cloud API | ||
| is required. If access is not allowed, fallback to using the [Drush](https://docs.docksal.io/fin/fin-pull/#drupal-drush) method. |
Member
There was a problem hiding this comment.
"To interact with Acquia through the Acquia CLI, ..."
Drush to Acquia only requires an SSH key. It's the Acquia CLI that requires the additional secret and key.
pull/README.md
Outdated
| `SECRET_ACQUIA_CLI_KEY` are required. Additionally, access to the Acquia Cloud API | ||
| is required. If access is not allowed, fallback to using the [Drush](https://docs.docksal.io/fin/fin-pull/#drupal-drush) method. | ||
|
|
||
| More information on working with [Docksal with Acquia Drush](https://docs.docksal.io/tools/acquia-drush). |
Member
There was a problem hiding this comment.
More information on working with Acquia CLI in Docksal.
pull/README.md
Outdated
| is set. More information on [generating tokens](https://pantheon.io/docs/machine-tokens/) | ||
| can be found in Pantheon's documentation. | ||
|
|
||
| More information on working with [Docksal with Pantheon](https://docs.docksal.io/tools/terminus). |
pull/README.md
Outdated
| is set. For more information on [creating CLI tokens](https://docs.platform.sh/gettingstarted/cli/api-tokens.html) | ||
| for use with the Platform.sh CLI tool, consult with Platform's documentation. | ||
|
|
||
| More information on working with [Docksal with Platform.sh](https://docs.docksal.io/tools/platformsh). |
pull/README.md
Outdated
| url: http://example.com | ||
| ``` | ||
|
|
||
| More information on working with [Docksal and WP-CLI](https://docs.docksal.io/tools/wp-cli). |
shelane
approved these changes
Mar 14, 2022
lmakarov
approved these changes
Apr 1, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moving from Core into it's own addon