Conversation
shelane
previously approved these changes
Aug 30, 2022
Member
shelane
left a comment
shelane
left a comment
There was a problem hiding this comment.
Looks very similar to a custom command that I have.
Contributor
Author
|
@shelane thanks. Yea... it's been hanging out for a while and I figure it'd be nice to share. I could set no option to toggle the state, but figure doing nothing is always... non-destructive. |
Member
|
Please create in your PR an update to the readme file with this included in alphabetical order in the list. |
shelane
approved these changes
Oct 14, 2022
shelane
requested changes
Oct 14, 2022
xdebug/xdebug
Outdated
| fin up | ||
| ;; | ||
| *) | ||
| echo "Please tell me 'on' or 'off'." |
Member
There was a problem hiding this comment.
Sorry, just one more nit-picky little thing. For consistency of verbiage with other commands, can you change this to:
"Usage: fin xdebug <on|off>"
and add exit 1 on the next line?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A very simple addon to turn xdebug on or off (that mirrors DDEV's function)