key update from webservice #309
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #309 +/- ##
=============================================
+ Coverage 23.78% 23.83% +0.04%
- Complexity 397 400 +3
=============================================
Files 48 48
Lines 6046 6046
Branches 800 800
=============================================
+ Hits 1438 1441 +3
Misses 4418 4418
+ Partials 190 187 -3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
denis-yuen
requested review from
a team,
kathy-t and
svonworl
and removed request for
a team
kathy-t
approved these changes
Jun 10, 2025
svonworl
approved these changes
Jun 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix broken nightly builds with snapshot of webservice build (need to update keymap)
While at it, removed an artifactory description that seems to slow down builds a lot, not sure why but it seems to (replicated locally)
Review Instructions
Wait till next nightly cli build, see if it passes or continues to get a gpg error
Issue
n/a
Security
If there are any concerns that require extra attention from the security team, highlight them here.
Please make sure that you've checked the following before submitting your pull request. Thanks!
./mvnw clean install