Skip to content

Conversation

@denis-yuen
Copy link
Member

@denis-yuen denis-yuen commented May 16, 2025

Description
Branched from #2002
After some experimentation, found that a small test was blocking a java 17.0.5 update (I think really a node 16.16.0 to node 18.12.0 ) mini update and an nginx behaviour change going to Java 19 (undocumented and only the package number changes which is why previous attempts overlooked it as unlikely).

Review Instructions
Integration tests should finally pass when running with newer Java versions

Issue
https://ucsc-cgl.atlassian.net/browse/SEAB-6612
Previous painful attempts at #2002

Security
None

  • Check that your code compiles by running npm run build
  • Ensure that the PR targets the correct branch. Check the milestone or fix version of the ticket.
  • If this is the first time you're submitting a PR or even if you just need a refresher, consider reviewing our style guide
  • Do not bypass Angular sanitization (bypassSecurityTrustHtml, etc.), or justify why you need to do so
  • If displaying markdown, use the markdown-wrapper component, which does extra sanitization
  • Do not use cookies, although this may change in the future
  • Run npm audit and ensure you are not introducing new vulnerabilities
  • Do due diligence on new 3rd party libraries, checking for CVEs
  • Don't allow user-uploaded images to be served from the Dockstore domain
  • If this PR is for a user-facing feature, create and link a documentation ticket for this feature (usually in the same milestone as the linked issue). Style points if you create a documentation PR directly and link that instead.
  • Check whether this PR disables tests. If it legitimately needs to disable a test, create a new ticket to re-enable it in a specific milestone.

@denis-yuen denis-yuen self-assigned this May 16, 2025
@codecov
Copy link

codecov bot commented May 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 41.48%. Comparing base (8298cbf) to head (8113b0b).
Report is 1 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2103      +/-   ##
===========================================
- Coverage    41.83%   41.48%   -0.36%     
===========================================
  Files          392      392              
  Lines        12381    12381              
  Branches      2958     2958              
===========================================
- Hits          5180     5136      -44     
- Misses        4885     4930      +45     
+ Partials      2316     2315       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

This reverts commit 950647b.
@denis-yuen
Copy link
Member Author

Notes for Tuesday:

  • had to disable RegEx check that started dying (no idea why)
  • random nginx permissions change seems to explain Java 19 failures

@denis-yuen
Copy link
Member Author

Note to self: this marks the point where 19.0.2-browsers works

@denis-yuen denis-yuen changed the title Feature/java crawl2 Java update for ui2 testing May 20, 2025
@denis-yuen
Copy link
Member Author

Ok, Java 21 and accessibility working, only npm audit is left which is unrelated

@denis-yuen denis-yuen marked this pull request as ready for review May 20, 2025 15:20
@denis-yuen
Copy link
Member Author

@denis-yuen denis-yuen requested review from a team, kathy-t and svonworl and removed request for a team May 20, 2025 15:26
name: Prepapre nginx config
name: Prepare nginx config
command: sed "s%REPLACEME%`pwd`%" .circleci/nginx.conf.tmpl > .circleci/nginx.conf
- run:
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could not find documentation, didn't seem to be a version change, but sometime in the late 17.0.x releases, nginx requires more explicit permissions to content

Comment on lines 463 to 464
# update to key may only be for Java 19
wget -q -O - https://dl.google.com/linux/linux_signing_key.pub | sudo apt-key add -
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this still needed?

@sonarqubecloud
Copy link

@denis-yuen denis-yuen merged commit f640650 into develop May 23, 2025
19 of 20 checks passed
@denis-yuen denis-yuen deleted the feature/java_crawl2 branch May 23, 2025 21:03
@denis-yuen denis-yuen changed the title Java update for ui2 testing Java update for ui2 testing - java 21 Jun 2, 2025
@denis-yuen denis-yuen mentioned this pull request Jun 2, 2025
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants