-
Notifications
You must be signed in to change notification settings - Fork 16
Java update for ui2 testing - java 21 #2103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #2103 +/- ##
===========================================
- Coverage 41.83% 41.48% -0.36%
===========================================
Files 392 392
Lines 12381 12381
Branches 2958 2958
===========================================
- Hits 5180 5136 -44
- Misses 4885 4930 +45
+ Partials 2316 2315 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This reverts commit 950647b.
|
Notes for Tuesday:
|
|
Note to self: this marks the point where |
|
Ok, Java 21 and accessibility working, only npm audit is left which is unrelated |
|
Spin-off for https://ucsc-cgl.atlassian.net/browse/SEAB-7158 |
| name: Prepapre nginx config | ||
| name: Prepare nginx config | ||
| command: sed "s%REPLACEME%`pwd`%" .circleci/nginx.conf.tmpl > .circleci/nginx.conf | ||
| - run: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could not find documentation, didn't seem to be a version change, but sometime in the late 17.0.x releases, nginx requires more explicit permissions to content
.circleci/config.yml
Outdated
| # update to key may only be for Java 19 | ||
| wget -q -O - https://dl.google.com/linux/linux_signing_key.pub | sudo apt-key add - |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this still needed?
|



Description
Branched from #2002
After some experimentation, found that a small test was blocking a java 17.0.5 update (I think really a node 16.16.0 to node 18.12.0 ) mini update and an nginx behaviour change going to Java 19 (undocumented and only the package number changes which is why previous attempts overlooked it as unlikely).
Review Instructions
Integration tests should finally pass when running with newer Java versions
Issue
https://ucsc-cgl.atlassian.net/browse/SEAB-6612
Previous painful attempts at #2002
Security
None
npm run buildmarkdown-wrappercomponent, which does extra sanitizationnpm auditand ensure you are not introducing new vulnerabilities