fix: only save applicable page images#226
Conversation
Merge ProtectionsYour pull request matches the following merge protections and will not be merged until they are valid. 🔴 Require two reviewer for test updatesThis rule is failing.When test data is updated, we require two reviewers
🟢 Enforce conventional commitWonderful, this rule succeeded.Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/
|
e3a50f7 to
9022b61
Compare
|
@ClemDoum this looks good, but the CI build appears frozen. |
Signed-off-by: Clément Doumouro <clement.doumouro@gmail.com>
4d82723 to
8ef0bd4
Compare
|
✅ DCO Check Passed Thanks @ClemDoum, all your commits are properly signed off. 🎉 |
Merge ProtectionsYour pull request matches the following merge protections and will not be merged until they are valid. 🟢 Enforce conventional commitWonderful, this rule succeeded.Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/
🟢 Require two reviewer for test updatesWonderful, this rule succeeded.When test data is updated, we require two reviewers
|
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know! |
|
@ClemDoum you can ignore my previous message, the latest changes have been incorporated & this is now merged. |
Bug description
fixes: #179
When saving a markdown page by page (potentially to keep track of page size in characters for instance) images of the whole documents were save. This had 2 majors drawbacks:
Fix
Changed
DoclingDocument._with_pictures_refsto take thepage_noand forward it toiter_items()