feat: add subscript & superscript formatting #319
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Panos Vagenas <[email protected]>
vagenas
requested review from
nassarofficial,
cau-git,
PeterStaar-IBM and
dolfim-ibm
Merge ProtectionsYour pull request matches the following merge protections and will not be merged until they are valid. 🟢 Enforce conventional commitWonderful, this rule succeeded.Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/
🟢 Require two reviewer for test updatesWonderful, this rule succeeded.When test data is updated, we require two reviewers
|
PeterStaar-IBM
requested changes
Jun 5, 2025
docling_core/types/doc/document.py
Outdated
| @@ -836,6 +836,8 @@ class Formatting(BaseModel): | |||
| italic: bool = False | |||
| underline: bool = False | |||
| strikethrough: bool = False | |||
| subscript: bool = False | |||
There was a problem hiding this comment.
this will need to be an enum: you can not have subscript and superscript equal to false.
Signed-off-by: Panos Vagenas <[email protected]>
Codecov ReportAttention: Patch coverage is
📢 Thoughts on this report? Let us know! |
dolfim-ibm
approved these changes
Jun 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added subscript & superscript support, for now only leveraged in HTML (the Markdown syntax seems to be "uncommon" & won't render e.g. on VS Code).