feat: Visualizer for table cells #325
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Peter Staar <[email protected]>
Merge ProtectionsYour pull request matches the following merge protections and will not be merged until they are valid. 🟢 Enforce conventional commitWonderful, this rule succeeded.Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/
🟢 Require two reviewer for test updatesWonderful, this rule succeeded.When test data is updated, we require two reviewers
|
Codecov ReportAttention: Patch coverage is
📢 Thoughts on this report? Let us know! |
Signed-off-by: Peter Staar <[email protected]>
Signed-off-by: Peter Staar <[email protected]>
vagenas
reviewed
Jun 11, 2025
There was a problem hiding this comment.
Have left couple comments inline.
Generally:
- seeing TableVisualizer, I am expecting it to also visualize the TableItem's top-level bbox (granted that this would overlap with LayoutVisualizer's output)
- I'd recheck the scope, name (e.g. rename to TableCellVisualizer if applicable), & exposed params
| raise RuntimeError(f"Cannot visualize page-image for {page_nr}") | ||
|
|
||
| else: | ||
| _log.error("Can not yet visualise tables with multiple provenances") |
There was a problem hiding this comment.
As this does not stop the execution, I would rather use a warning instead of error.
Signed-off-by: Peter Staar <[email protected]>
vagenas
approved these changes
Jun 11, 2025
cau-git
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.