Skip to content

fix: build package distribution #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Mar 27, 2025
Merged

fix: build package distribution #21

merged 5 commits into from
Mar 27, 2025

Conversation

ceberam
Copy link
Collaborator

@ceberam ceberam commented Mar 26, 2025

  • set project license according to PEP 639
  • sync the environment after updating the package version and ensure that uv.lock is commited
  • add missing package files
  • replace setuptools with hatchling as build system

Replace the project license declaration (legacy) with a valid SPDX license expression
according to PEP 639.

Signed-off-by: Cesar Berrospi Ramis <[email protected]>
@ceberam ceberam self-assigned this Mar 26, 2025
Copy link

mergify bot commented Mar 26, 2025

Merge Protections

Your pull request matches the following merge protections and will not be merged until they are valid.

🟢 Enforce conventional commit

Wonderful, this rule succeeded.

Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/

  • title ~= ^(fix|feat|docs|style|refactor|perf|test|build|ci|chore|revert)(?:\(.+\))?(!)?:

@ceberam ceberam added the bug Something isn't working label Mar 26, 2025
ceberam added 4 commits March 27, 2025 00:22
During the release, the uv.lock file needs to be updated to include
the new release version.

Signed-off-by: Cesar Berrospi Ramis <[email protected]>
Signed-off-by: Cesar Berrospi Ramis <[email protected]>
Signed-off-by: Cesar Berrospi Ramis <[email protected]>
@ceberam ceberam force-pushed the fix/build-distribution branch from fd02d02 to 166f19a Compare March 26, 2025 23:27
@vagenas
Copy link
Contributor

vagenas commented Mar 27, 2025

@ceberam looks good, just can you provide some context to the switch from setuptools to hatchling?

@ceberam
Copy link
Collaborator Author

ceberam commented Mar 27, 2025

@ceberam looks good, just can you provide some context to the switch from setuptools to hatchling?

After finding out that the first distribution was built incorrectly, I was not able to configure the setuptools options to produce the right build for our flat-layout. Neither with automatic discovery nor with the find directive. It may be related to the uv build front end that we use in this repository.
The uv tool suggests hatchling by default and other apps like pytest also point at that build system. With hatchling I was able to run the uv build and get the source and binary distributions as expected.

@ceberam ceberam merged commit d9b949c into main Mar 27, 2025
5 checks passed
@ceberam ceberam deleted the fix/build-distribution branch March 27, 2025 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants