Skip to content

Do not configure deprecated proxy options when native lazy ghost objects are enabled #1898

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 7, 2025

Conversation

mbabker
Copy link
Contributor

@mbabker mbabker commented Jul 3, 2025

Partially addresses #1895

This will stop calling the ORM Configuration class' deprecated setAutoGenerateProxyClasses(), setProxyDir(), and setProxyNamespace() methods when the native lazy objects feature is enabled and soft-deprecates the relevant config options by noting they'll be ignored in this case. This purposely only stops calling those methods with ORM 3.5 since 3.4 doesn't have the deprecation notices and issues like doctrine/orm#11997 meant with 3.4.0 specifically there were a couple of cases where not configuring them led to errors.

@mbabker mbabker force-pushed the proxy-config-deprecations branch from f4344bc to c50ce02 Compare July 3, 2025 15:47
@ostrolucky ostrolucky added this to the 2.16.0 milestone Jul 3, 2025
Copy link
Member

@greg0ire greg0ire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Is the plan to hard deprecate it in 2.17.x?

@ostrolucky ostrolucky merged commit 3a854f8 into doctrine:2.16.x Jul 7, 2025
12 checks passed
@mbabker mbabker deleted the proxy-config-deprecations branch July 7, 2025 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants