Use var_export for scalar default values #989
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will be good enough to cut a 3.4.2 release. It will:
self
#988 and give us more time to deal with current approach's shenanigansIt is worth mentioning that we will NOT support correctly double-quoted strings in complex default values until a fix in PHP is present (or a workaround is found). Given people never really had a chance to start using such values, I believe this is OK.
@ampaze @Lustmored may I ask you to test your apps with this PR instead of released 3.4.1?