throw DBALException replace throw Exception #4062
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## 2.10.x #4062 +/- ##
============================================
- Coverage 73.32% 73.31% -0.02%
- Complexity 5031 5032 +1
============================================
Files 215 215
Lines 12825 12827 +2
============================================
Hits 9404 9404
- Misses 3421 3423 +2
Continue to review full report at Codecov.
|
morozov
requested changes
Jun 13, 2020
| try { | ||
| $statement = $this->_conn->query(...$args); | ||
| } catch (Throwable $ex) { | ||
| throw DBALException::driverExceptionDuringQuery($this->_driver, $ex, $args[0]); |
There was a problem hiding this comment.
Although this is correct, this is a breaking change and should be retargeted against 3.0.x.
| $statement = $this->_conn->query(...$args); | ||
| try { | ||
| $statement = $this->_conn->query(...$args); | ||
| } catch (Throwable $ex) { |
There was a problem hiding this comment.
A driver-level connection should be expected to only throw a DriverException (see #4072).
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When i use the function ping() in MasterSlaveConnection, can not catch the Exception. Because in the class Doctrine\DBAL\Connection, the function ping only can catch DBALException.However the function query() in MasterSlaveConnection not throw it.