Use the proper keys and values for command array #604
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaapio
approved these changes
Aug 21, 2024
That array is supposed to map command names to command arguments. Using array_unshift resulted in a crash when using --clear-build-cache, as well as 2 unnecessary assertions.
SenseException
force-pushed
the
fix-clear-build-cache
branch
from
85d00c9 to
be728c2
Compare
SenseException
approved these changes
Aug 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
That array is supposed to map command names to command arguments. Using array_unshift resulted in a crash when using
--clear-build-cache, as well as 2 unnecessary assertions.Extracted from #594