Avoid copying sidebar #605
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaapio
reviewed
Aug 21, 2024
lib/Docs/RST/RSTCopier.php
Outdated
| @@ -56,6 +57,10 @@ public function copyRst(Project $project, ProjectVersion $version): void | |||
| $files = $this->rstFileRepository->getSourceFiles($language->getPath()); | |||
|
|
|||
| foreach ($files as $file) { | |||
| if (str_ends_with($file, 'sidebar.rst')) { | |||
There was a problem hiding this comment.
please be aware that this might result into all files with sidebar.rst to be skipped. a file like who-to-render-sidebar.rst will also not be copied.
That's why my initial implementation was looking so odd.
greg0ire
force-pushed
the
avoid-copying-sidebar
branch
from
d7d3466 to
5745622
Compare
jaapio
approved these changes
Aug 21, 2024
It should not be built as a document.
SenseException
force-pushed
the
avoid-copying-sidebar
branch
from
5745622 to
1974f47
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It should not be built as a document.
Extracted from #594