1 to 2 #854
Merged
1 to 2 #854
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bump to PHP 8
make annotations also attributes
convert provided documents to attributes instead of annotations
convert tests to use attributes instead of annotations
fix test setup
link attributes documentation in toc
Merged
|
@dbu Any update on this PR? |
|
thanks for asking. i wanted to remove annotations completely in #858 rather than trying to fix legacy things for the upcoming version. but did not find time to continue on that. it looks like not much is missing to wrap that one up - if you want to give it a go you would be very welcome, otherwise i will try again next week. |
adjust phpdoc annotations to work around phpstan/phpstan#10399
remove obsolete annotation mapping
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.