Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Throw error if null or undefined #65

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Throw error if null or undefined #65

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fd7a9bd
Give empty string in place of undefined
Mar 21, 2016
288b882
Throws error if null or undefined
May 31, 2016
6e2948d
Removed changes to test
May 31, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion slug.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ function symbols(code) {
}

function slug(string, opts) {
string = string.toString();
string = (string || '').toString();
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe it would be more semantic to just have the function return null or undefined if the string is null or undefined?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In my opinion, null and undefined should be considered a developer mistake and throw.

if (string === null || string === undefined)
  throw new Error('input must be castable to string')

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point. Should it throw for anything other than a string?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In my opinion, yes.

if ('string' === typeof opts)
opts = {replacement:opts};
opts = opts || {};
Expand Down