Fix total_payment_confirmed #153
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I detected on the Dogecoin hackathon website wen checking invoices that the total_payment_confirmed were not being added and so my background confirmations failled to check after the latest update This changes verifies and adds the total_payment_confirmed correctly
raffecat
requested changes
Jun 23, 2025
| @@ -134,19 +133,18 @@ func (i *Invoice) ToPublic() PublicInvoice { | |||
| Estimate: 0, // XXX meant to estimate time until confirmation | |||
| } | |||
|
|
|||
| if i.LastIncomingAmount.IsPositive() { | |||
| if i.LastPaidAmount.IsPositive() { | |||
There was a problem hiding this comment.
I'm not convinced this is right. The reason is: LastPaidAmount is only confirmed amounts after 6 blocks, but PartDetected is meant to be an early notification that some payment is incoming, so it uses IncomingAmount the unconfirmed balance after 1 block.
| pub.PartDetected = true | ||
| } | ||
|
|
||
| if i.LastIncomingAmount.GreaterThanOrEqual(i.Total) { | ||
| if i.LastPaidAmount.GreaterThanOrEqual(i.Total) { |
There was a problem hiding this comment.
The same situation. TotalDetected is notice that the whole payment is incoming, but not confirmed yet.
There was a problem hiding this comment.
strange, because even if enough blocks, in my case 1 block is set, it dosent add to the database that was full paid :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I detected on the Dogecoin hackathon website wen checking invoices that the total_payment_confirmed were not being added and so my background confirmations failled to check after the latest update
This changes verifies and adds the total_payment_confirmed correctly